From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70FF2C43613 for ; Mon, 24 Jun 2019 07:43:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4E5CE2089F for ; Mon, 24 Jun 2019 07:43:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728025AbfFXHnA (ORCPT ); Mon, 24 Jun 2019 03:43:00 -0400 Received: from stargate.chelsio.com ([12.32.117.8]:59507 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726795AbfFXHnA (ORCPT ); Mon, 24 Jun 2019 03:43:00 -0400 Received: from localhost (kumbhalgarh.blr.asicdesigners.com [10.193.185.255]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id x5O7guox010740; Mon, 24 Jun 2019 00:42:57 -0700 Date: Mon, 24 Jun 2019 13:12:55 +0530 From: Raju Rangoju To: David Miller Cc: netdev@vger.kernel.org, nirranjan@chelsio.com, dt@chelsio.com Subject: Re: [PATCH net-next 1/4] cxgb4: Re-work the logic for mps refcounting Message-ID: <20190624074254.GA10420@chelsio.com> References: <20190621143636.20422-1-rajur@chelsio.com> <20190621143636.20422-2-rajur@chelsio.com> <20190623.113423.151452943171499414.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190623.113423.151452943171499414.davem@davemloft.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sunday, June 06/23/19, 2019 at 11:34:23 -0700, David Miller wrote: > From: Raju Rangoju > Date: Fri, 21 Jun 2019 20:06:33 +0530 > > > +struct mps_entries_ref { > > + struct list_head list; > > + u8 addr[ETH_ALEN]; > > + u8 mask[ETH_ALEN]; > > + u16 idx; > > + atomic_t refcnt; > > +}; > > Since you're making this change, please use refcnt_t. Sure. Will send out v2 with suggested changes. Thanks, Raju