From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07510C4646C for ; Mon, 24 Jun 2019 22:46:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D4A8D20665 for ; Mon, 24 Jun 2019 22:46:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="1JNiS8o8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727026AbfFXWqD (ORCPT ); Mon, 24 Jun 2019 18:46:03 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:43782 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726931AbfFXWqD (ORCPT ); Mon, 24 Jun 2019 18:46:03 -0400 Received: by mail-qk1-f196.google.com with SMTP id m14so11072653qka.10 for ; Mon, 24 Jun 2019 15:46:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=l+t11w+lYzgMdf9afpAfNi/wBZxJpJdB0Y+rhM6lHks=; b=1JNiS8o8LLcLGJ7yDeuoGqe7R53WxwUnBJ473OA/Sj94hjFkUtbMZgxLmpjtFcBKa6 N8tfCq4i4n89X7x24u4RaZsPtxHqdSZxpQvXnuae5hnCD5wud1xsEgxlwfhTEoVI9cPt g3jQIXuW7CiLlgUVdgWO8zSkn1nQjlMb25O4W634mUf1mJezM/d1gtgwSbKc319j57bs dLGovYfEKNj36SFTmOEAS+n8b5B1My2OgGKfdHQcGOBv6EgC/AuW1Oqplc0bR0zzeUgo jYXXxiIhD1iH9bA0rFt9Qmmx+ThDGH8ng7MqzQSE2+OlYR7eeju/cBxmDLZn9ZaILbBX PPLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=l+t11w+lYzgMdf9afpAfNi/wBZxJpJdB0Y+rhM6lHks=; b=ZF/pifEyrgA44Kn6mIfOU5T9F7t4SGJI5DHpWWTTjH3dxHGK42LRCD/S+7DzreEBV9 ILQCIK5r4tbSU2Xh4cJocSVuOs92cz4Pc+27HNupVKiSk/nQykrpse/vQ/mHiXJKZG6g 4k5jHA3feG0MTxu3LzV7dTwOurIXpU4MP/jsKRIET5Y1tNIZ0fUVzBlx94JR8NnmQHtI hOcLzdpASD7Uo2YjXxxcLE7IBTa7L2RIRPrEGe7xiQft5sYL7gmFKEW/I7LrrXV2PoM2 +RO34M8p0sx9REJkJiNKhkJ4i/IYS7a0nmw4Guca+jCF5P0rRU59W4kP8JZHPgY64J5l +5Qw== X-Gm-Message-State: APjAAAXXN2HD2UX2bQ9TY9JH/llBWFh4wKU+9Ot6fqEL1zGjf3fUHlAV TR2NAHot/KKB/TjHsSXrkIP3Kw== X-Google-Smtp-Source: APXvYqx2gLjuzKn7dYRM+5cj5gK6T/0dtP3tloIyQ3TQPgnYyzTA7/groXjMvqklxlRwTCwpzetNWQ== X-Received: by 2002:ae9:e608:: with SMTP id z8mr114743476qkf.182.1561416362271; Mon, 24 Jun 2019 15:46:02 -0700 (PDT) Received: from cakuba.netronome.com ([66.60.152.14]) by smtp.gmail.com with ESMTPSA id k40sm7384209qta.50.2019.06.24.15.46.00 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 24 Jun 2019 15:46:02 -0700 (PDT) Date: Mon, 24 Jun 2019 15:45:58 -0700 From: Jakub Kicinski To: Brian Vazquez Cc: Brian Vazquez , Alexei Starovoitov , Daniel Borkmann , "David S . Miller" , Stanislav Fomichev , Willem de Bruijn , Petar Penkov , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org Subject: Re: [RFC PATCH 2/6] bpf: add BPF_MAP_DUMP command to access more than one entry per call Message-ID: <20190624154558.65c31561@cakuba.netronome.com> In-Reply-To: <20190621231650.32073-3-brianvv@google.com> References: <20190621231650.32073-1-brianvv@google.com> <20190621231650.32073-3-brianvv@google.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 21 Jun 2019 16:16:46 -0700, Brian Vazquez wrote: > @@ -385,6 +386,14 @@ union bpf_attr { > __u64 flags; > }; > > + struct { /* struct used by BPF_MAP_DUMP command */ > + __u32 map_fd; There is a hole here, perhaps flags don't have to be 64 bit? > + __aligned_u64 prev_key; > + __aligned_u64 buf; > + __aligned_u64 buf_len; /* input/output: len of buf */ > + __u64 flags; > + } dump; > + > struct { /* anonymous struct used by BPF_PROG_LOAD command */ > __u32 prog_type; /* one of enum bpf_prog_type */ > __u32 insn_cnt;