From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53700C48BD6 for ; Tue, 25 Jun 2019 19:47:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 319912063F for ; Tue, 25 Jun 2019 19:47:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728103AbfFYTrj (ORCPT ); Tue, 25 Jun 2019 15:47:39 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:49918 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726776AbfFYTrj (ORCPT ); Tue, 25 Jun 2019 15:47:39 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B0852126A2067; Tue, 25 Jun 2019 12:47:38 -0700 (PDT) Date: Tue, 25 Jun 2019 12:47:38 -0700 (PDT) Message-Id: <20190625.124738.1945131933038317898.davem@davemloft.net> To: ssuryaextr@gmail.com Cc: netdev@vger.kernel.org, dsahern@gmail.com Subject: Re: [PATCH net] ipv4: Use return value of inet_iif() for __raw_v4_lookup in the while loop From: David Miller In-Reply-To: <20190625001406.6437-1-ssuryaextr@gmail.com> References: <20190625001406.6437-1-ssuryaextr@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 25 Jun 2019 12:47:38 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Stephen Suryaputra Date: Mon, 24 Jun 2019 20:14:06 -0400 > In commit 19e4e768064a8 ("ipv4: Fix raw socket lookup for local > traffic"), the dif argument to __raw_v4_lookup() is coming from the > returned value of inet_iif() but the change was done only for the first > lookup. Subsequent lookups in the while loop still use skb->dev->ifIndex. > > Signed-off-by: Stephen Suryaputra Applied and queued up for -stable. I added the appropriate Fixes: tag, please do so next time.