From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9357DC48BD7 for ; Tue, 25 Jun 2019 20:34:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 729262085A for ; Tue, 25 Jun 2019 20:34:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726772AbfFYUeQ (ORCPT ); Tue, 25 Jun 2019 16:34:16 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:50704 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726274AbfFYUeQ (ORCPT ); Tue, 25 Jun 2019 16:34:16 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 06923128FF110; Tue, 25 Jun 2019 13:34:15 -0700 (PDT) Date: Tue, 25 Jun 2019 13:34:15 -0700 (PDT) Message-Id: <20190625.133415.1358006150660179231.davem@davemloft.net> To: jon.maloy@ericsson.com Cc: netdev@vger.kernel.org, gordan.mihaljevic@dektech.com.au, tung.q.nguyen@dektech.com.au, hoang.h.le@dektech.com.au, canh.d.luu@dektech.com.au, ying.xue@windriver.com, tipc-discussion@lists.sourceforge.net Subject: Re: [net-next 1/1] tipc: simplify stale link failure criteria From: David Miller In-Reply-To: <1561477003-25362-1-git-send-email-jon.maloy@ericsson.com> References: <1561477003-25362-1-git-send-email-jon.maloy@ericsson.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 25 Jun 2019 13:34:16 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jon Maloy Date: Tue, 25 Jun 2019 17:36:43 +0200 > In commit a4dc70d46cf1 ("tipc: extend link reset criteria for stale > packet retransmission") we made link retransmission failure events > dependent on the link tolerance, and not only of the number of failed > retransmission attempts, as we did earlier. This works well. However, > keeping the original, additional criteria of 99 failed retransmissions > is now redundant, and may in some cases lead to failure detection > times in the order of minutes instead of the expected 1.5 sec link > tolerance value. > > We now remove this criteria altogether. > > Acked-by: Ying Xue > Signed-off-by: Jon Maloy Applied.