From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4C97C48BD5 for ; Tue, 25 Jun 2019 04:59:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A74220659 for ; Tue, 25 Jun 2019 04:59:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="U3rQceye"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="YVAzPyj8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727463AbfFYE7z (ORCPT ); Tue, 25 Jun 2019 00:59:55 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59164 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726804AbfFYE7z (ORCPT ); Tue, 25 Jun 2019 00:59:55 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 29EE4607CA; Tue, 25 Jun 2019 04:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561438794; bh=md7kE4BdEUt2E2wtf3+wWFZnGTK4S+hsToX1pbW5wv8=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=U3rQceye6dl4WnHbimh5n4MbwQB+0gSuQw0dIhK7s6h7SreGr2E2JtxF2dW90jgZZ uNQR5tAUHhfzZCFdLmDL4fVSl/Q6DsMNTBG9Ib6LttPZb89t1B6495PL5joKAmXuWa 9vABLYz/VC4sxHMGlu7fI3L1lA6w9I4nLQw6L/x8= Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 042A36019D; Tue, 25 Jun 2019 04:59:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561438793; bh=md7kE4BdEUt2E2wtf3+wWFZnGTK4S+hsToX1pbW5wv8=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=YVAzPyj8GmFwNIeDgJjypXDgACHEZNPbv/VTdpe+5Jizqyk1ikShjHT8DZJcaDiJM cNVoj2VtaKYfx/+K5xRGfzA2dk75H2at6gcBJS1Ae9tPDJXC11eZ+Wb5LmhKlh9A0D OSJPHGTnaTUL47gv/Xxvd2KLIrCWHo/LgCSssvUU= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 042A36019D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtlwifi: remove redundant assignment to variable badworden From: Kalle Valo In-Reply-To: <20190530184044.8479-1-colin.king@canonical.com> References: <20190530184044.8479-1-colin.king@canonical.com> To: Colin King Cc: Ping-Ke Shih , "David S . Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190625045954.29EE4607CA@smtp.codeaurora.org> Date: Tue, 25 Jun 2019 04:59:54 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Colin King wrote: > From: Colin Ian King > > The variable badworden is assigned with a value that is never read and > it is re-assigned a new value immediately afterwards. The assignment is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > Acked-by: Larry Finger Patch applied to wireless-drivers-next.git, thanks. 5315f9d40191 rtlwifi: remove redundant assignment to variable badworden -- https://patchwork.kernel.org/patch/10969175/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches