From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Parshuram Raju Thombare <pthombar@cadence.com>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"f.fainelli@gmail.com" <f.fainelli@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rafal Ciepiela <rafalc@cadence.com>,
Anil Joy Varughese <aniljoy@cadence.com>,
Piotr Sroka <piotrs@cadence.com>
Subject: Re: [PATCH v5 2/5] net: macb: add support for sgmii MAC-PHY interface
Date: Tue, 25 Jun 2019 10:29:30 +0100 [thread overview]
Message-ID: <20190625092930.ootk5nvbkqqvfbtd@shell.armlinux.org.uk> (raw)
In-Reply-To: <SN2PR07MB2480B53AFE512F46986A1CAFC1E30@SN2PR07MB2480.namprd07.prod.outlook.com>
On Tue, Jun 25, 2019 at 09:26:29AM +0000, Parshuram Raju Thombare wrote:
> >In which case, gem_phylink_validate() must clear the support mask when
> >SGMII mode is requested to indicate that the interface mode is not
> >supported.
> >The same goes for _all_ other PHY link modes that the hardware does not
> >actually support, such as PHY_INTERFACE_MODE_10GKR...
> If interface is not supported by hardware probe returns with error, so we don't
> net interface is not registered at all.
That does not negate my comment above.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-06-25 9:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 12:10 [PATCH v5 0/5] net: macb: cover letter Parshuram Thombare
2019-06-24 12:10 ` [PATCH v5 1/5] net: macb: add phylink support Parshuram Thombare
2019-06-24 12:11 ` [PATCH v5 2/5] net: macb: add support for sgmii MAC-PHY interface Parshuram Thombare
2019-06-24 13:42 ` Russell King - ARM Linux admin
2019-06-25 9:26 ` Parshuram Raju Thombare
2019-06-25 9:29 ` Russell King - ARM Linux admin [this message]
2019-06-25 9:38 ` Parshuram Raju Thombare
2019-06-25 10:34 ` Russell King - ARM Linux admin
2019-06-25 11:22 ` Parshuram Raju Thombare
2019-06-24 12:11 ` [PATCH v5 3/5] net: macb: add support for c45 PHY Parshuram Thombare
2019-06-24 12:12 ` [PATCH v5 4/5] net: macb: add support for high speed interface Parshuram Thombare
2019-06-24 13:47 ` Russell King - ARM Linux admin
2019-06-25 8:49 ` Parshuram Raju Thombare
2019-06-25 9:03 ` Russell King - ARM Linux admin
2019-06-25 9:29 ` Parshuram Raju Thombare
2019-06-25 8:55 ` Parshuram Raju Thombare
2019-06-24 12:12 ` [PATCH v5 5/5] net: macb: parameter added to cadence ethernet controller DT binding Parshuram Thombare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625092930.ootk5nvbkqqvfbtd@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=aniljoy@cadence.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=piotrs@cadence.com \
--cc=pthombar@cadence.com \
--cc=rafalc@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).