From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A40F6C48BD6 for ; Tue, 25 Jun 2019 09:29:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 77DE320883 for ; Tue, 25 Jun 2019 09:29:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="1AIJJNhr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731558AbfFYJ3k (ORCPT ); Tue, 25 Jun 2019 05:29:40 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:49280 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727789AbfFYJ3k (ORCPT ); Tue, 25 Jun 2019 05:29:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=IOs08vRJYw1qJiIbOQmayB+PkMsOoQ5W5ST49dzietI=; b=1AIJJNhrxhQNgKmIE3GuEHKhE D6DomYPYPrbk4HYTCd4AM/NN5Ttg+d5YcvPC6FqdT44nfSIllS1+cK4r9QbFT+Q1xkGhS+LaBbwje 1NPdhy4DQardJmPjA3mvz2rcqOaNxepTtTCC8mqXgaZEkeSM4PWwK2qjE4MZ2iB2RMiH2GUF7HT5h LCTKGfrgY6w1ysjLjvUjDbLmgLnKPjcQ+ZLH1mjtPjUwl02Udp4FToA+c+bn4Id/xqDHik/UM/xKb vHM7AEMRAWEtJ3+diRTU20ZmjRc48quvzYmBCjRdUD9KDgh1s3kK+yYtx0D58cHy5Ma6KTqkz8V3b xghNvokuQ==; Received: from shell.armlinux.org.uk ([2001:4d48:ad52:3201:5054:ff:fe00:4ec]:58976) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1hfhlc-0005TP-Q2; Tue, 25 Jun 2019 10:29:32 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.89) (envelope-from ) id 1hfhla-00076N-Is; Tue, 25 Jun 2019 10:29:30 +0100 Date: Tue, 25 Jun 2019 10:29:30 +0100 From: Russell King - ARM Linux admin To: Parshuram Raju Thombare Cc: "andrew@lunn.ch" , "nicolas.ferre@microchip.com" , "davem@davemloft.net" , "f.fainelli@gmail.com" , "netdev@vger.kernel.org" , "hkallweit1@gmail.com" , "linux-kernel@vger.kernel.org" , Rafal Ciepiela , Anil Joy Varughese , Piotr Sroka Subject: Re: [PATCH v5 2/5] net: macb: add support for sgmii MAC-PHY interface Message-ID: <20190625092930.ootk5nvbkqqvfbtd@shell.armlinux.org.uk> References: <1561378210-11033-1-git-send-email-pthombar@cadence.com> <1561378274-12357-1-git-send-email-pthombar@cadence.com> <20190624134233.suowuortj5dcbxdg@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jun 25, 2019 at 09:26:29AM +0000, Parshuram Raju Thombare wrote: > >In which case, gem_phylink_validate() must clear the support mask when > >SGMII mode is requested to indicate that the interface mode is not > >supported. > >The same goes for _all_ other PHY link modes that the hardware does not > >actually support, such as PHY_INTERFACE_MODE_10GKR... > If interface is not supported by hardware probe returns with error, so we don't > net interface is not registered at all. That does not negate my comment above. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up