From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBB48C48BD4 for ; Tue, 25 Jun 2019 10:05:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4F50215EA for ; Tue, 25 Jun 2019 10:05:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727295AbfFYKF7 convert rfc822-to-8bit (ORCPT ); Tue, 25 Jun 2019 06:05:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51150 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726274AbfFYKF7 (ORCPT ); Tue, 25 Jun 2019 06:05:59 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EAC1D821EF; Tue, 25 Jun 2019 10:05:54 +0000 (UTC) Received: from carbon (ovpn-200-34.brq.redhat.com [10.40.200.34]) by smtp.corp.redhat.com (Postfix) with ESMTP id C54845C231; Tue, 25 Jun 2019 10:05:45 +0000 (UTC) Date: Tue, 25 Jun 2019 12:05:43 +0200 From: Jesper Dangaard Brouer To: Toke =?UTF-8?B?SMO4aWxhbmQtSsO4cmdlbnNlbg==?= Cc: brouer@redhat.com, "Daniel T. Lee" , Daniel Borkmann , Alexei Starovoitov , bpf@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v2] samples: bpf: make the use of xdp samples consistent Message-ID: <20190625120543.12b25184@carbon> In-Reply-To: <878stqdoc9.fsf@toke.dk> References: <20190625005536.2516-1-danieltimlee@gmail.com> <878stqdoc9.fsf@toke.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 25 Jun 2019 10:05:58 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 25 Jun 2019 11:08:22 +0200 Toke Høiland-Jørgensen wrote: > "Daniel T. Lee" writes: > > > Currently, each xdp samples are inconsistent in the use. > > Most of the samples fetch the interface with it's name. > > (ex. xdp1, xdp2skb, xdp_redirect_cpu, xdp_sample_pkts, etc.) > > > > But some of the xdp samples are fetching the interface with > > ifindex by command argument. > > > > This commit enables xdp samples to fetch interface with it's name > > without changing the original index interface fetching. > > ( fetching in the same way as xdp_sample_pkts_user.c does.) > > > > Signed-off-by: Daniel T. Lee > > --- > > Changes in v2: > > - added xdp_redirect_user.c, xdp_redirect_map_user.c > > Great, thanks! > > Acked-by: Toke Høiland-Jørgensen Great you basically solved one of our TODOs: - TODO Change sample programs to accept ifnames as well as indexes https://github.com/xdp-project/xdp-project/blob/master/xdp-project.org#next-change-sample-programs-to-accept-ifnames-as-well-as-indexes Acked-by: Jesper Dangaard Brouer -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer