From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07574C48BD5 for ; Tue, 25 Jun 2019 14:51:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D31172080C for ; Tue, 25 Jun 2019 14:51:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="H31eTT/z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731171AbfFYOvK (ORCPT ); Tue, 25 Jun 2019 10:51:10 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:58142 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730777AbfFYOvK (ORCPT ); Tue, 25 Jun 2019 10:51:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZgkOw5D3P/fjtwFB3Tcj7uXmbq5UBoyXYtEvi0Cd5KQ=; b=H31eTT/zqFXIrWiHqPMM5QkYYw WYq1+nRYh3eLMpTzHQG7qEy5Ae75pW2TtG9fvMLqz9NRepPGejbzjVEun4doa8/2kLWioOy9Y1+of K6kD32lrJfTt4gjLMqNUeOymXU2cJiC1NAO1NH6KvOvx3nayhOaziJTYa9M8Y6+BDXBc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hfmmn-000747-F7; Tue, 25 Jun 2019 16:51:05 +0200 Date: Tue, 25 Jun 2019 16:51:05 +0200 From: Andrew Lunn To: Katsuhiro Suzuki Cc: Jose Abreu , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" , Joao Pinto , "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue Subject: Re: [PATCH net-next] net: stmmac: Fix the case when PHY handle is not present Message-ID: <20190625145105.GA4722@lunn.ch> References: <351cce38d1c572d8b171044f2856c7fae9f89cbc.1561450696.git.joabreu@synopsys.com> <78EB27739596EE489E55E81C33FEC33A0B9D78A2@DE02WEMBXB.internal.synopsys.com> <5859e2c5-112f-597c-3bd5-e30e96b86152@katsuster.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5859e2c5-112f-597c-3bd5-e30e96b86152@katsuster.net> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jun 25, 2019 at 11:40:00PM +0900, Katsuhiro Suzuki wrote: > Hello Jose, > > This patch works fine with my Tinker Board. Thanks a lot! > > Tested-by: Katsuhiro Suzuki > > > BTW, from network guys point of view, is it better to add a phy node > into device trees that have no phy node such as the Tinker Board? Hi Katsuhiro It makes it less ambiguous if there is a phy-handle. It is then very clear which PHY should be used. For a development board, which people can be tinkering around with, there is a chance they add a second PHY to the MDIO bus, or an Ethernet switch, etc. Without explicitly listing the PHY, it might get the wrong one. However this is generally a problem if phy_find_first() is used. I think in this case, something is setting priv->plat->phy_addr, so it is also clearly defined which PHY to use. Andrew