From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, URIBL_SBL,URIBL_SBL_A autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82291C48BD3 for ; Wed, 26 Jun 2019 17:14:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5AAFB208E3 for ; Wed, 26 Jun 2019 17:14:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726725AbfFZROz (ORCPT ); Wed, 26 Jun 2019 13:14:55 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:38186 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726674AbfFZROy (ORCPT ); Wed, 26 Jun 2019 13:14:54 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id AD81314BEB0DE; Wed, 26 Jun 2019 10:14:53 -0700 (PDT) Date: Wed, 26 Jun 2019 10:14:53 -0700 (PDT) Message-Id: <20190626.101453.103222375095547363.davem@davemloft.net> To: yuehaibing@huawei.com Cc: sdf@google.com, jianbol@mellanox.com, jiri@mellanox.com, mirq-linux@rere.qmqm.pl, willemb@google.com, sdf@fomichev.me, jiri@resnulli.us, j.vosburgh@gmail.com, vfalico@gmail.com, andy@greyhouse.net, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] team: Always enable vlan tx offload From: David Miller In-Reply-To: <20190626160339.35152-1-yuehaibing@huawei.com> References: <20190624135007.GA17673@nanopsycho> <20190626160339.35152-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Jun 2019 10:14:54 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: YueHaibing Date: Thu, 27 Jun 2019 00:03:39 +0800 > We should rather have vlan_tci filled all the way down > to the transmitting netdevice and let it do the hw/sw > vlan implementation. > > Suggested-by: Jiri Pirko > Signed-off-by: YueHaibing Applied and queued up for -stable, thanks.