From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D217DC48BD6 for ; Thu, 27 Jun 2019 02:30:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A981C2182B for ; Thu, 27 Jun 2019 02:30:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727109AbfF0CaN (ORCPT ); Wed, 26 Jun 2019 22:30:13 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:45648 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726786AbfF0CaN (ORCPT ); Wed, 26 Jun 2019 22:30:13 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 4D7D414DDE50E; Wed, 26 Jun 2019 19:30:12 -0700 (PDT) Date: Wed, 26 Jun 2019 19:30:11 -0700 (PDT) Message-Id: <20190626.193011.1423969728804124428.davem@davemloft.net> To: lucien.xin@gmail.com Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com, nhorman@tuxdriver.com, syzkaller-bugs@googlegroups.com Subject: Re: [PATCH net] sctp: change to hold sk after auth shkey is created successfully From: David Miller In-Reply-To: <14de0d292dc2fe01ecadaba00feb925b337b558f.1561393305.git.lucien.xin@gmail.com> References: <14de0d292dc2fe01ecadaba00feb925b337b558f.1561393305.git.lucien.xin@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 26 Jun 2019 19:30:12 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Xin Long Date: Tue, 25 Jun 2019 00:21:45 +0800 > Now in sctp_endpoint_init(), it holds the sk then creates auth > shkey. But when the creation fails, it doesn't release the sk, > which causes a sk defcnf leak, > > Here to fix it by only holding the sk when auth shkey is created > successfully. > > Fixes: a29a5bd4f5c3 ("[SCTP]: Implement SCTP-AUTH initializations.") > Reported-by: syzbot+afabda3890cc2f765041@syzkaller.appspotmail.com > Reported-by: syzbot+276ca1c77a19977c0130@syzkaller.appspotmail.com > Signed-off-by: Xin Long Applied and queued up for -stable, thanks Xin.