From: David Miller <davem@davemloft.net>
To: c0d1n61at3@gmail.com
Cc: skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Linux-kernel-mentees][PATCH v2] packet: Fix undefined behavior in bit shift
Date: Thu, 27 Jun 2019 10:34:24 -0700 (PDT) [thread overview]
Message-ID: <20190627.103424.2376390104509352.davem@davemloft.net> (raw)
In-Reply-To: <20190627165726.p6k3tugjs2gzgnjh@rYz3n>
From: Jiunn Chang <c0d1n61at3@gmail.com>
Date: Thu, 27 Jun 2019 11:57:28 -0500
> On Thu, Jun 27, 2019 at 09:22:53AM -0700, David Miller wrote:
>> From: Shuah Khan <skhan@linuxfoundation.org>
>> Date: Wed, 26 Jun 2019 21:32:52 -0600
>>
>> > On 6/26/19 9:25 PM, Jiunn Chang wrote:
>> >> Shifting signed 32-bit value by 31 bits is undefined. Changing most
>> >> significant bit to unsigned.
>> >> Changes included in v2:
>> >> - use subsystem specific subject lines
>> >> - CC required mailing lists
>> >>
>> >
>> > These version change lines don't belong in the change log.
>>
>> For networking changes I actually like the change lines to be in the
>> commit log. So please don't stray people this way, thanks.
>
> Hello David,
>
> Would you like me to send v3 with the change log in the patch description?
I'll use v2 which had this done correctly.
next prev parent reply other threads:[~2019-06-27 17:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190627010137.5612-1-c0d1n61at3@gmail.com>
2019-06-27 3:25 ` [Linux-kernel-mentees][PATCH v2] packet: Fix undefined behavior in bit shift Jiunn Chang
2019-06-27 3:32 ` Shuah Khan
2019-06-27 16:22 ` David Miller
2019-06-27 16:52 ` Shuah Khan
2019-06-27 17:05 ` Alexei Starovoitov
2019-06-27 17:08 ` Shuah Khan
2019-06-27 16:57 ` Jiunn Chang
2019-06-27 17:34 ` David Miller [this message]
2019-06-27 5:04 ` [Linux-kernel-mentees][PATCH v3] " Jiunn Chang
2019-06-29 18:06 ` [Linux-kernel-mentees][PATCH v2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627.103424.2376390104509352.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=c0d1n61at3@gmail.com \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox