From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 70064C48BE4 for ; Thu, 27 Jun 2019 19:53:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56AA220B7C for ; Thu, 27 Jun 2019 19:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726561AbfF0Txl (ORCPT ); Thu, 27 Jun 2019 15:53:41 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:59482 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726426AbfF0Txl (ORCPT ); Thu, 27 Jun 2019 15:53:41 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 08BE113CB348B; Thu, 27 Jun 2019 12:53:39 -0700 (PDT) Date: Thu, 27 Jun 2019 12:53:39 -0700 (PDT) Message-Id: <20190627.125339.707372206595841703.davem@davemloft.net> To: paulb@mellanox.com Cc: jiri@mellanox.com, roid@mellanox.com, yossiku@mellanox.com, ozsh@mellanox.com, marcelo.leitner@gmail.com, netdev@vger.kernel.org, aconole@redhat.com, wangzhike@jd.com, ronye@mellanox.com, nst-kernel@redhat.com, john.hurley@netronome.com, simon.horman@netronome.com, jpettit@ovn.org Subject: Re: [PATCH net-next v2 1/4] net/sched: Introduce action ct From: David Miller In-Reply-To: <1561038141-31370-2-git-send-email-paulb@mellanox.com> References: <1561038141-31370-1-git-send-email-paulb@mellanox.com> <1561038141-31370-2-git-send-email-paulb@mellanox.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 27 Jun 2019 12:53:40 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Paul Blakey Date: Thu, 20 Jun 2019 16:42:18 +0300 > +struct tcf_ct_params { ... > + struct rcu_head rcu; > + > +}; Please get ride of that empty line after the 'rcu' member. > + switch (skb->protocol) { > + case htons(ETH_P_IP): > + family = NFPROTO_IPV4; > + break; > + case htons(ETH_P_IPV6): > + family = NFPROTO_IPV6; > + break; > + default: > + break; Break statement is not indented properly. > +static __net_init int ct_init_net(struct net *net) > +{ > + struct tc_ct_action_net *tn = net_generic(net, ct_net_id); > + unsigned int n_bits = FIELD_SIZEOF(struct tcf_ct_params, labels) * 8; Reverse christmas tree here please.