From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E408BC48BD6 for ; Thu, 27 Jun 2019 00:45:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BBE6820815 for ; Thu, 27 Jun 2019 00:45:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561596319; bh=fzq8r8aSrA1sUEK3/KDv+Rfz7jaSN8NSi/MfukWHwTc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=pEr1a/Qof42Ba/S/4i3DpDZQWBSXEUu1+Pjj6Cu8VL35WlO3Qdy6r/ldj22s/MEeg oM66mdInj96o/TcrwHFA6w8pkLUgfKrGJLCeAhZPCjipIw03bzIf2LU/L4wLKRRmud IokmVgmF4+8qhCMMoMnN1rYaWE+zNZdYXBCuXwrs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727887AbfF0ApR (ORCPT ); Wed, 26 Jun 2019 20:45:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:45182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729056AbfF0AlV (ORCPT ); Wed, 26 Jun 2019 20:41:21 -0400 Received: from sasha-vm.mshome.net (unknown [107.242.116.147]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 32E3821855; Thu, 27 Jun 2019 00:41:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561596080; bh=fzq8r8aSrA1sUEK3/KDv+Rfz7jaSN8NSi/MfukWHwTc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CT2gIVWg2isNi19+4ZYYLsfDRnXEqQotUmAgmFX2vJ1xgaNEgVVHbluQHyuI5ylBF IZapZR0HWu07EMxGXiAaUmeESEf7tGVIqF/OAK9EKJq4THkRDVpwwf8oUNkwcvUItQ /gQmsRZ5wGuoKblkI41KFAFsdbsnzuz6ZuhM5ba4= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Lin Yi , Anna Schumaker , Sasha Levin , linux-nfs@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 35/35] net :sunrpc :clnt :Fix xps refcount imbalance on the error path Date: Wed, 26 Jun 2019 20:39:23 -0400 Message-Id: <20190627003925.21330-35-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190627003925.21330-1-sashal@kernel.org> References: <20190627003925.21330-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Lin Yi [ Upstream commit b96226148491505318228ac52624956bd98f9e0c ] rpc_clnt_add_xprt take a reference to struct rpc_xprt_switch, but forget to release it before return, may lead to a memory leak. Signed-off-by: Lin Yi Signed-off-by: Anna Schumaker Signed-off-by: Sasha Levin --- net/sunrpc/clnt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index 6d118357d9dc..9259529e0412 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -2706,6 +2706,7 @@ int rpc_clnt_add_xprt(struct rpc_clnt *clnt, xprt = xprt_iter_xprt(&clnt->cl_xpi); if (xps == NULL || xprt == NULL) { rcu_read_unlock(); + xprt_switch_put(xps); return -EAGAIN; } resvport = xprt->resvport; -- 2.20.1