From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FBDAC4321A for ; Fri, 28 Jun 2019 16:45:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E95D02086D for ; Fri, 28 Jun 2019 16:45:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726819AbfF1QpA (ORCPT ); Fri, 28 Jun 2019 12:45:00 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:47548 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726667AbfF1Qo7 (ORCPT ); Fri, 28 Jun 2019 12:44:59 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id F210A14E03B20; Fri, 28 Jun 2019 09:44:58 -0700 (PDT) Date: Fri, 28 Jun 2019 09:44:57 -0700 (PDT) Message-Id: <20190628.094457.246058762133976195.davem@davemloft.net> To: brouer@redhat.com Cc: ilias.apalodimas@linaro.org, netdev@vger.kernel.org, jaswinder.singh@linaro.org, ard.biesheuvel@linaro.org, bjorn.topel@intel.com, magnus.karlsson@intel.com, daniel@iogearbox.net, ast@kernel.org, makita.toshiaki@lab.ntt.co.jp, jakub.kicinski@netronome.com, john.fastabend@gmail.com, maciejromanfijalkowski@gmail.com Subject: Re: [PATCH 3/3, net-next] net: netsec: add XDP support From: David Miller In-Reply-To: <20190628153552.78a8c5ad@carbon> References: <1561718355-13919-1-git-send-email-ilias.apalodimas@linaro.org> <1561718355-13919-4-git-send-email-ilias.apalodimas@linaro.org> <20190628153552.78a8c5ad@carbon> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 28 Jun 2019 09:44:59 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jesper Dangaard Brouer Date: Fri, 28 Jun 2019 15:35:52 +0200 > On Fri, 28 Jun 2019 13:39:15 +0300 > Ilias Apalodimas wrote: > >> +static int netsec_xdp_setup(struct netsec_priv *priv, struct bpf_prog *prog, >> + struct netlink_ext_ack *extack) >> +{ >> + struct net_device *dev = priv->ndev; >> + struct bpf_prog *old_prog; >> + >> + /* For now just support only the usual MTU sized frames */ >> + if (prog && dev->mtu > 1500) { >> + NL_SET_ERR_MSG_MOD(extack, "Jumbo frames not supported on XDP"); >> + return -EOPNOTSUPP; >> + } >> + >> + if (netif_running(dev)) >> + netsec_netdev_stop(dev); >> + >> + /* Detach old prog, if any */ >> + old_prog = xchg(&priv->xdp_prog, prog); >> + if (old_prog) >> + bpf_prog_put(old_prog); >> + >> + if (netif_running(dev)) >> + netsec_netdev_open(dev); > > Shouldn't the if-statement be if (!netif_running(dev)) Hmmm, does netsec_netdev_stop() clear the running flag? That just runs the driver internal routine and doesn't update IFF_UP et al. which the core networking would do.