From: David Miller <davem@davemloft.net>
To: vedang.patel@intel.com
Cc: netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com,
jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us,
intel-wired-lan@lists.osuosl.org, vinicius.gomes@intel.com,
l@dorileo.org, jakub.kicinski@netronome.com, m-karicheri2@ti.com,
sergei.shtylyov@cogentembedded.com, eric.dumazet@gmail.com,
aaron.f.brown@intel.com
Subject: Re: [PATCH net-next v6 0/8] net/sched: Add txtime-assist support for taprio.
Date: Fri, 28 Jun 2019 14:46:47 -0700 (PDT) [thread overview]
Message-ID: <20190628.144647.570493656550419800.davem@davemloft.net> (raw)
In-Reply-To: <1561500439-30276-1-git-send-email-vedang.patel@intel.com>
From: Vedang Patel <vedang.patel@intel.com>
Date: Tue, 25 Jun 2019 15:07:11 -0700
> Currently, we are seeing packets being transmitted outside their
> timeslices. We can confirm that the packets are being dequeued at the right
> time. So, the delay is induced after the packet is dequeued, because
> taprio, without any offloading, has no control of when a packet is actually
> transmitted.
>
> In order to solve this, we are making use of the txtime feature provided by
> ETF qdisc. Hardware offloading needs to be supported by the ETF qdisc in
> order to take advantage of this feature. The taprio qdisc will assign
> txtime (in skb->tstamp) for all the packets which do not have the txtime
> allocated via the SO_TXTIME socket option. For the packets which already
> have SO_TXTIME set, taprio will validate whether the packet will be
> transmitted in the correct interval.
>
> In order to support this, the following parameters have been added:
> - flags (taprio): This is added in order to support different offloading
> modes which will be added in the future.
> - txtime-delay (taprio): This indicates the minimum time it will take for
> the packet to hit the wire after it reaches taprio_enqueue(). This is
> useful in determining whether we can transmit the packet in the remaining
> time if the gate corresponding to the packet is currently open.
> - skip_skb_check (ETF): ETF currently drops any packet which does not have
> the SO_TXTIME socket option set. This check can be skipped by specifying
> this option.
...
Series applied, thanks.
prev parent reply other threads:[~2019-06-28 21:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 22:07 [PATCH net-next v6 0/8] net/sched: Add txtime-assist support for taprio Vedang Patel
2019-06-25 22:07 ` [PATCH net-next v6 1/8] igb: clear out skb->tstamp after reading the txtime Vedang Patel
2019-06-26 19:44 ` Jeff Kirsher
2019-06-26 20:06 ` Patel, Vedang
2019-06-28 3:01 ` Brown, Aaron F
2019-06-25 22:07 ` [PATCH net-next v6 2/8] etf: Don't use BIT() in UAPI headers Vedang Patel
2019-06-25 22:07 ` [PATCH net-next v6 3/8] etf: Add skip_sock_check Vedang Patel
2019-06-25 22:07 ` [PATCH net-next v6 4/8] taprio: calculate cycle_time when schedule is installed Vedang Patel
2019-06-25 22:07 ` [PATCH net-next v6 5/8] taprio: Remove inline directive Vedang Patel
2019-06-25 22:07 ` [PATCH net-next v6 6/8] taprio: Add support for txtime-assist mode Vedang Patel
2019-06-25 22:07 ` [PATCH net-next v6 7/8] taprio: make clock reference conversions easier Vedang Patel
2019-06-25 22:07 ` [PATCH net-next v6 8/8] taprio: Adjust timestamps for TCP packets Vedang Patel
2019-06-28 21:46 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628.144647.570493656550419800.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aaron.f.brown@intel.com \
--cc=eric.dumazet@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jakub.kicinski@netronome.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=l@dorileo.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=vedang.patel@intel.com \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox