From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: netdev@vger.kernel.org, jaswinder.singh@linaro.org,
ard.biesheuvel@linaro.org, bjorn.topel@intel.com,
magnus.karlsson@intel.com, daniel@iogearbox.net, ast@kernel.org,
makita.toshiaki@lab.ntt.co.jp, jakub.kicinski@netronome.com,
john.fastabend@gmail.com, davem@davemloft.net,
maciejromanfijalkowski@gmail.com, brouer@redhat.com
Subject: Re: [PATCH 1/3, net-next] net: netsec: Use page_pool API
Date: Fri, 28 Jun 2019 15:03:17 +0200 [thread overview]
Message-ID: <20190628150317.0b05e7ab@carbon> (raw)
In-Reply-To: <1561718355-13919-2-git-send-email-ilias.apalodimas@linaro.org>
On Fri, 28 Jun 2019 13:39:13 +0300
Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote:
> @@ -1079,11 +1095,22 @@ static int netsec_setup_rx_dring(struct netsec_priv *priv)
> }
>
> netsec_rx_fill(priv, 0, DESC_NUM);
> + err = xdp_rxq_info_reg(&dring->xdp_rxq, priv->ndev, 0);
> + if (err)
> + goto err_out;
> +
> + err = xdp_rxq_info_reg_mem_model(&dring->xdp_rxq, MEM_TYPE_PAGE_POOL,
> + dring->page_pool);
> + if (err) {
> + page_pool_free(dring->page_pool);
> + goto err_out;
> + }
>
> return 0;
>
> err_out:
> - return -ENOMEM;
> + netsec_uninit_pkt_dring(priv, NETSEC_RING_RX);
> + return err;
> }
I think you need to move page_pool_free(dring->page_pool) until after
netsec_uninit_pkt_dring() as it use dring->page_pool.
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-06-28 13:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 10:39 [PATCH 0/3, net-next] net: netsec: Add XDP Support Ilias Apalodimas
2019-06-28 10:39 ` [PATCH 1/3, net-next] net: netsec: Use page_pool API Ilias Apalodimas
2019-06-28 13:03 ` Jesper Dangaard Brouer [this message]
2019-06-28 13:04 ` Jesper Dangaard Brouer
2019-06-28 16:43 ` David Miller
2019-06-28 17:19 ` Ilias Apalodimas
2019-06-28 17:41 ` Jesper Dangaard Brouer
2019-06-28 10:39 ` [PATCH 2/3, net-next] net: page_pool: add helper function for retrieving dma direction Ilias Apalodimas
2019-06-28 13:07 ` Jesper Dangaard Brouer
2019-06-28 10:39 ` [PATCH 3/3, net-next] net: netsec: add XDP support Ilias Apalodimas
2019-06-28 13:35 ` Jesper Dangaard Brouer
2019-06-28 16:44 ` David Miller
2019-06-28 16:47 ` Ilias Apalodimas
2019-06-28 17:23 ` Maciej Fijalkowski
2019-06-28 17:59 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628150317.0b05e7ab@carbon \
--to=brouer@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=ilias.apalodimas@linaro.org \
--cc=jakub.kicinski@netronome.com \
--cc=jaswinder.singh@linaro.org \
--cc=john.fastabend@gmail.com \
--cc=maciejromanfijalkowski@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).