From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A90C6C4321A for ; Fri, 28 Jun 2019 13:03:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 86DEB20645 for ; Fri, 28 Jun 2019 13:03:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726660AbfF1NDd (ORCPT ); Fri, 28 Jun 2019 09:03:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41108 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726558AbfF1NDd (ORCPT ); Fri, 28 Jun 2019 09:03:33 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8CABB7FDCD; Fri, 28 Jun 2019 13:03:29 +0000 (UTC) Received: from carbon (ovpn-200-45.brq.redhat.com [10.40.200.45]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3ACA960A97; Fri, 28 Jun 2019 13:03:19 +0000 (UTC) Date: Fri, 28 Jun 2019 15:03:17 +0200 From: Jesper Dangaard Brouer To: Ilias Apalodimas Cc: netdev@vger.kernel.org, jaswinder.singh@linaro.org, ard.biesheuvel@linaro.org, bjorn.topel@intel.com, magnus.karlsson@intel.com, daniel@iogearbox.net, ast@kernel.org, makita.toshiaki@lab.ntt.co.jp, jakub.kicinski@netronome.com, john.fastabend@gmail.com, davem@davemloft.net, maciejromanfijalkowski@gmail.com, brouer@redhat.com Subject: Re: [PATCH 1/3, net-next] net: netsec: Use page_pool API Message-ID: <20190628150317.0b05e7ab@carbon> In-Reply-To: <1561718355-13919-2-git-send-email-ilias.apalodimas@linaro.org> References: <1561718355-13919-1-git-send-email-ilias.apalodimas@linaro.org> <1561718355-13919-2-git-send-email-ilias.apalodimas@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 28 Jun 2019 13:03:33 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 28 Jun 2019 13:39:13 +0300 Ilias Apalodimas wrote: > @@ -1079,11 +1095,22 @@ static int netsec_setup_rx_dring(struct netsec_priv *priv) > } > > netsec_rx_fill(priv, 0, DESC_NUM); > + err = xdp_rxq_info_reg(&dring->xdp_rxq, priv->ndev, 0); > + if (err) > + goto err_out; > + > + err = xdp_rxq_info_reg_mem_model(&dring->xdp_rxq, MEM_TYPE_PAGE_POOL, > + dring->page_pool); > + if (err) { > + page_pool_free(dring->page_pool); > + goto err_out; > + } > > return 0; > > err_out: > - return -ENOMEM; > + netsec_uninit_pkt_dring(priv, NETSEC_RING_RX); > + return err; > } I think you need to move page_pool_free(dring->page_pool) until after netsec_uninit_pkt_dring() as it use dring->page_pool. -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer