From: Stephen Hemminger <stephen@networkplumber.org>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Jiri Pirko <jiri@mellanox.com>,
netdev@vger.kernel.org, Aya Levin <ayal@mellanox.com>,
Moshe Shemesh <moshe@mellanox.com>
Subject: Re: [PATCH iproute2 v2 1/2] devlink: fix format string warning for 32bit targets
Date: Fri, 28 Jun 2019 15:21:43 -0700 [thread overview]
Message-ID: <20190628152143.1378fad8@hermes.lan> (raw)
In-Reply-To: <7a72ae0f9519e6a445d9712399d989fed648e6eb.1561660639.git.baruch@tkos.co.il>
On Thu, 27 Jun 2019 21:37:18 +0300
Baruch Siach <baruch@tkos.co.il> wrote:
> 32bit targets define uint64_t as long long unsigned. This leads to the
> following build warning:
>
> devlink.c: In function ‘pr_out_u64’:
> devlink.c:1729:11: warning: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘uint64_t {aka long long unsigned int}’ [-Wformat=]
> pr_out("%s %lu", name, val);
> ^
> devlink.c:59:21: note: in definition of macro ‘pr_out’
> fprintf(stdout, ##args); \
> ^~~~
>
> Use uint64_t specific conversion specifiers in the format string to fix
> that.
>
> Cc: Aya Levin <ayal@mellanox.com>
> Cc: Moshe Shemesh <moshe@mellanox.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Both patches applied.
prev parent reply other threads:[~2019-06-28 22:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 18:37 [PATCH iproute2 v2 1/2] devlink: fix format string warning for 32bit targets Baruch Siach
2019-06-27 18:37 ` [PATCH iproute2 v2 2/2] devlink: fix libc and kernel headers collision Baruch Siach
2019-06-28 22:21 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628152143.1378fad8@hermes.lan \
--to=stephen@networkplumber.org \
--cc=ayal@mellanox.com \
--cc=baruch@tkos.co.il \
--cc=jiri@mellanox.com \
--cc=moshe@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox