From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26879C4321A for ; Sat, 29 Jun 2019 13:30:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F36E2215EA for ; Sat, 29 Jun 2019 13:30:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rgSoSZSs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726865AbfF2NaU (ORCPT ); Sat, 29 Jun 2019 09:30:20 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:46946 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726731AbfF2NaU (ORCPT ); Sat, 29 Jun 2019 09:30:20 -0400 Received: by mail-wr1-f66.google.com with SMTP id n4so9003430wrw.13; Sat, 29 Jun 2019 06:30:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=d2Jq43JP+FXo0SKE8waIpqerNlOB9iz9yqcOCdjfmdc=; b=rgSoSZSshnnIj+7+FoCJgppZQCtJfnziD6J+wMfzEoJIwdF/zWTjj4NhK6tIgcQp2b KcM7prO9cDdIK6y4BpmUADxKBOGjlIt/+4sXbwpkIgAzatdMOgaZALI9mrOcsgn5yma2 Q6+ZRM9NGtANblb2E6YtVySZkRviLxDS3uZivh8ezH/L/ZMSIBnO8kjgBr9jif3GirvB 357Y1emRMgHD6+gPP5hnWnvzrp42BI30c8jZjwTGx3eIWIEHTJtLaa9IutxTto6UiXUD hCrYq4MYOKFEnkjkKWd1TmNVg4FKCOWV6RxZhn8wxK9IB4rs38naBUVw5X7QuXjxEYas 0Q2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=d2Jq43JP+FXo0SKE8waIpqerNlOB9iz9yqcOCdjfmdc=; b=Ow+rAEAW6MfdsXNNIXQOY0UHx56cIbDnq3NtYnnZuZi6cREg/moH0N2kup8qRdMxJ0 sIAQMPrZBcMMcLwTYbQuA48h5V10M1k3ZRkBDxh07ghmdbz/BKmVjV9zKtrN5cX1+UV8 b1GfVhHYZDPdisCCrjVyDM/2pGCONeOZEU6i+pqMvGyFfdpuv6lF/3wrICVpFTCt2W8M jkQhZzPEmY5NVgAR2vcPGTKx23HYHJiMgLFXwasVcn8ox3S/2m1w7TGXhdDJmVzXSvGn B/5cZ8wlrmrY5V3dgSMHz4Zgr5Hw7E1OdnxKdj/2vGpDZSaRZDj2C9FS9aRRYjkbbxdb vZjw== X-Gm-Message-State: APjAAAWKx1IxESl6hh8l2jRTXJ9dARZyq0g/aJAn36OIKj3JYWyHq4Gl 5zLCMpNqMyXt4Td5P+FsT++QnHo= X-Google-Smtp-Source: APXvYqwh3xpHdOYn1eXmBfg/Ga2I52jr36q3cei/9YvigCSJizufx6uHf7inNqFe+7in5AtbjjXuew== X-Received: by 2002:a5d:540e:: with SMTP id g14mr12676093wrv.346.1561815018265; Sat, 29 Jun 2019 06:30:18 -0700 (PDT) Received: from avx2 ([46.53.248.49]) by smtp.gmail.com with ESMTPSA id u25sm5195676wmc.3.2019.06.29.06.30.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 29 Jun 2019 06:30:17 -0700 (PDT) Date: Sat, 29 Jun 2019 16:29:59 +0300 From: Alexey Dobriyan To: "Hallsmark, Per" Cc: "David S. Miller" , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Subject: Re: [PATCH] let proc net directory inodes reflect to active net namespace Message-ID: <20190629132959.GA9370@avx2> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jun 25, 2019 at 10:36:06AM +0000, Hallsmark, Per wrote: > +struct proc_dir_entry *proc_net_mkdir(struct net *net, const char *name, > + struct proc_dir_entry *parent) > +{ > + struct proc_dir_entry *pde; > + > + pde = proc_mkdir_data(name, 0, parent, net); > + pde->proc_dops = &proc_net_dentry_ops; > + > + return pde; > +} This requires NULL check at least.