From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A81BFC0650E for ; Mon, 1 Jul 2019 11:07:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 892F7206A3 for ; Mon, 1 Jul 2019 11:07:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728274AbfGALHx (ORCPT ); Mon, 1 Jul 2019 07:07:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38972 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727645AbfGALHw (ORCPT ); Mon, 1 Jul 2019 07:07:52 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 872BD2F8BDF; Mon, 1 Jul 2019 11:07:52 +0000 (UTC) Received: from localhost (ovpn-204-140.brq.redhat.com [10.40.204.140]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2B93078540; Mon, 1 Jul 2019 11:07:52 +0000 (UTC) Date: Mon, 1 Jul 2019 13:07:51 +0200 From: Stanislaw Gruszka To: Soeren Moch Cc: Helmut Schaa , Kalle Valo , "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2] rt2x00usb: remove unnecessary rx flag checks Message-ID: <20190701110750.GB13992@redhat.com> References: <20190701105314.9707-1-smoch@web.de> <20190701105314.9707-2-smoch@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190701105314.9707-2-smoch@web.de> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 01 Jul 2019 11:07:52 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 01, 2019 at 12:53:14PM +0200, Soeren Moch wrote: > In contrast to the TX path, there is no need to separately read the transfer > status from the device after receiving RX data. Consequently, there is no > real STATUS_PENDING RX processing queue entry state. > Remove the unnecessary ENTRY_DATA_STATUS_PENDING flag checks from the RX path. > Also remove the misleading comment about reading RX status from device. > > Suggested-by: Stanislaw Gruszka > Signed-off-by: Soeren Moch Acked-by: Stanislaw Gruszka