From: Andrew Lunn <andrew@lunn.ch>
To: Sudarsana Reddy Kalluru <skalluru@marvell.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
mkalderon@marvell.com, aelior@marvell.com, jiri@resnulli.us
Subject: Re: [PATCH net-next 1/1] devlink: Add APIs to publish/unpublish the port parameters.
Date: Tue, 2 Jul 2019 18:11:33 +0200 [thread overview]
Message-ID: <20190702161133.GP30468@lunn.ch> (raw)
In-Reply-To: <20190702152056.31728-1-skalluru@marvell.com>
On Tue, Jul 02, 2019 at 08:20:56AM -0700, Sudarsana Reddy Kalluru wrote:
> The patch adds devlink interfaces for drivers to publish/unpublish the
> devlink port parameters.
Hi Sudarsana
A good commit message says more about 'why' than 'what'. I can see the
'what' by reading the code. But the 'why' is often not so clear.
Why would i want to unpublish port parameters?
Thanks
Andrew
next prev parent reply other threads:[~2019-07-02 16:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 15:20 [PATCH net-next 1/1] devlink: Add APIs to publish/unpublish the port parameters Sudarsana Reddy Kalluru
2019-07-02 16:11 ` Andrew Lunn [this message]
2019-07-02 16:18 ` Parav Pandit
2019-07-02 16:48 ` Andrew Lunn
2019-07-02 17:18 ` Parav Pandit
2019-07-03 2:46 ` Sudarsana Reddy Kalluru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702161133.GP30468@lunn.ch \
--to=andrew@lunn.ch \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=mkalderon@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).