From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=DATE_IN_PAST_03_06, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4058CC5B57D for ; Wed, 3 Jul 2019 01:43:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 061B520673 for ; Wed, 3 Jul 2019 01:43:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="TYEN0hMZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727025AbfGCBnY (ORCPT ); Tue, 2 Jul 2019 21:43:24 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:49726 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbfGCBnY (ORCPT ); Tue, 2 Jul 2019 21:43:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZknEdyZ1T4tCO8tHmRX93ivSc3EBe24oWP4BwRhJ2Q0=; b=TYEN0hMZKShpozJvjr/W9Y1Srn iaaqJaCW3jncpzHmm3Y+Dogy7v6DYmTCxq2ob5wMgxdl8KTfwzyiDXnN/xjBCAMvqUVit5pkeskg4 6vRmtmlc5vthbW7UyxuzRgsUekvcAeeRi2JwIK9aUBoeijunwkNHXb+mHSewJgugPPaA=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hiQRA-0000XZ-Q8; Tue, 02 Jul 2019 23:35:40 +0200 Date: Tue, 2 Jul 2019 23:35:40 +0200 From: Andrew Lunn To: Nikolay Aleksandrov Cc: Roopa Prabhu , bridge@lists.linux-foundation.org, netdev Subject: Re: Validation of forward_delay seems wrong... Message-ID: <20190702213540.GD28471@lunn.ch> References: <20190702204705.GC28471@lunn.ch> <55f24bfb-4239-dda8-24f8-26b6b2fa9f9e@cumulusnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55f24bfb-4239-dda8-24f8-26b6b2fa9f9e@cumulusnetworks.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > Hi Andrew, > The man page is wrong, these have been in USER_HZ scaled clock_t format from the beginning. > TBH a lot of the time/delay bridge config options are messed up like that. Hi Nikola Yes, that is a mess. arch/alpha/include/asm/param.h:# define USER_HZ 1024 arch/ia64/include/asm/param.h:# define USER_HZ HZ include/asm-generic/param.h:# define USER_HZ 100 And ia64 does # define HZ CONFIG_HZ So it seems pretty hard for user space to get this right in a generic fashion. Andrew