From: David Miller <davem@davemloft.net>
To: maheshb@google.com
Cc: netdev@vger.kernel.org, edumazet@google.com, mahesh@bandewar.net,
geert@linux-m68k.org
Subject: Re: [PATCH next] loopback: fix lockdep splat
Date: Wed, 03 Jul 2019 11:24:59 -0700 (PDT) [thread overview]
Message-ID: <20190703.112459.875695376158111859.davem@davemloft.net> (raw)
In-Reply-To: <20190703061631.84485-1-maheshb@google.com>
From: Mahesh Bandewar <maheshb@google.com>
Date: Tue, 2 Jul 2019 23:16:31 -0700
> dev_init_scheduler() and dev_activate() expect the caller to
> hold RTNL. Since we don't want blackhole device to be initialized
> per ns, we are initializing at init.
>
> [ 3.855027] Call Trace:
> [ 3.855034] dump_stack+0x67/0x95
> [ 3.855037] lockdep_rcu_suspicious+0xd5/0x110
> [ 3.855044] dev_init_scheduler+0xe3/0x120
> [ 3.855048] ? net_olddevs_init+0x60/0x60
> [ 3.855050] blackhole_netdev_init+0x45/0x6e
> [ 3.855052] do_one_initcall+0x6c/0x2fa
> [ 3.855058] ? rcu_read_lock_sched_held+0x8c/0xa0
> [ 3.855066] kernel_init_freeable+0x1e5/0x288
> [ 3.855071] ? rest_init+0x260/0x260
> [ 3.855074] kernel_init+0xf/0x180
> [ 3.855076] ? rest_init+0x260/0x260
> [ 3.855078] ret_from_fork+0x24/0x30
>
> Fixes: 4de83b88c66 ("loopback: create blackhole net device similar to loopack.")
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied.
prev parent reply other threads:[~2019-07-03 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 6:16 [PATCH next] loopback: fix lockdep splat Mahesh Bandewar
2019-07-03 8:45 ` Geert Uytterhoeven
2019-07-03 18:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703.112459.875695376158111859.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).