From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A02C06513 for ; Wed, 3 Jul 2019 18:30:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FE0521882 for ; Wed, 3 Jul 2019 18:30:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727108AbfGCSaG (ORCPT ); Wed, 3 Jul 2019 14:30:06 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:60558 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725933AbfGCSaG (ORCPT ); Wed, 3 Jul 2019 14:30:06 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6A17D140DA5B3; Wed, 3 Jul 2019 11:30:05 -0700 (PDT) Date: Wed, 03 Jul 2019 11:30:05 -0700 (PDT) Message-Id: <20190703.113005.69711790321030429.davem@davemloft.net> To: yuehaibing@huawei.com Cc: jaswinder.singh@linaro.org, ast@kernel.org, ilias.apalodimas@linaro.org, daniel@iogearbox.net, jakub.kicinski@netronome.com, hawk@kernel.org, netdev@vger.kernel.org, xdp-newbies@vger.kernel.org, bpf@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net-next] net: socionext: remove set but not used variable 'pkts' From: David Miller In-Reply-To: <20190703024213.191191-1-yuehaibing@huawei.com> References: <20190703024213.191191-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 03 Jul 2019 11:30:05 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: YueHaibing Date: Wed, 3 Jul 2019 02:42:13 +0000 > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/ethernet/socionext/netsec.c: In function 'netsec_clean_tx_dring': > drivers/net/ethernet/socionext/netsec.c:637:15: warning: > variable 'pkts' set but not used [-Wunused-but-set-variable] > > It is not used since commit ba2b232108d3 ("net: netsec: add XDP support") > > Signed-off-by: YueHaibing > --- > drivers/net/ethernet/socionext/netsec.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/socionext/netsec.c b/drivers/net/ethernet/socionext/netsec.c > index 5544a722543f..015d1ec5436a 100644 > --- a/drivers/net/ethernet/socionext/netsec.c > +++ b/drivers/net/ethernet/socionext/netsec.c > @@ -634,7 +634,7 @@ static void netsec_set_rx_de(struct netsec_priv *priv, > static bool netsec_clean_tx_dring(struct netsec_priv *priv) > { > struct netsec_desc_ring *dring = &priv->desc_ring[NETSEC_RING_TX]; > - unsigned int pkts, bytes; > + unsigned int bytes; > struct netsec_de *entry; > int tail = dring->tail; > int cnt = 0; This breaks the reverse christmas-tree ordering of the local variables in this function. Please move the 'bytes' declaration down by two lines when you make this change. Thanks.