From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B774C0650E for ; Wed, 3 Jul 2019 18:41:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5F39B21852 for ; Wed, 3 Jul 2019 18:41:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727014AbfGCSlm (ORCPT ); Wed, 3 Jul 2019 14:41:42 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:60814 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726430AbfGCSlm (ORCPT ); Wed, 3 Jul 2019 14:41:42 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id ED3F71411AB95; Wed, 3 Jul 2019 11:41:41 -0700 (PDT) Date: Wed, 03 Jul 2019 11:41:41 -0700 (PDT) Message-Id: <20190703.114141.21086700743761959.davem@davemloft.net> To: lucien.xin@gmail.com Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org, marcelo.leitner@gmail.com, nhorman@tuxdriver.com Subject: Re: [PATCH net] sctp: count data bundling sack chunk for outctrlchunks From: David Miller In-Reply-To: <62e917e312bc582e96fa19b502561e37ca7f91a6.1562149220.git.lucien.xin@gmail.com> References: <62e917e312bc582e96fa19b502561e37ca7f91a6.1562149220.git.lucien.xin@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 03 Jul 2019 11:41:42 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Xin Long Date: Wed, 3 Jul 2019 18:20:20 +0800 > Now all ctrl chunks are counted for asoc stats.octrlchunks and net > SCTP_MIB_OUTCTRLCHUNKS either after queuing up or bundling, other > than the chunk maked and bundled in sctp_packet_bundle_sack, which > caused 'outctrlchunks' not consistent with 'inctrlchunks' in peer. > > This issue exists since very beginning, here to fix it by increasing > both net SCTP_MIB_OUTCTRLCHUNKS and asoc stats.octrlchunks when sack > chunk is maked and bundled in sctp_packet_bundle_sack. > > Reported-by: Ja Ram Jeon > Signed-off-by: Xin Long Applied.