From: David Miller <davem@davemloft.net>
To: ast@domdv.de
Cc: netdev@vger.kernel.org, sd@queasysnail.net
Subject: Re: [PATCH net-next 0/3 v2] macsec: a few cleanups in the receive path
Date: Wed, 03 Jul 2019 13:42:28 -0700 (PDT) [thread overview]
Message-ID: <20190703.134228.1805959660993963992.davem@davemloft.net> (raw)
In-Reply-To: <7ec44dd08280f0b32dcf18aa35f687fc227c0197.camel@domdv.de>
From: Andreas Steinmetz <ast@domdv.de>
Date: Tue, 02 Jul 2019 22:49:54 +0200
> This patchset removes some unnecessary code in the receive path of the
> macsec driver, and re-indents the error handling after calling
> macsec_decrypt to make the post-processing clearer.
>
> This is a combined effort of Sabrina Dubroca <sd@queasysnail.net> and me.
>
> Change in 3/3:
>
> The patch now only moves the IS_ERR(skb) case under the block where
> macsec_decrypt() is called, but not the call to macsec_post_decrypt().
>
I really don't like these changes, especially patches #1 and #2.
Like Willem I don't think you can blindly remove the share check like
this (and you ignored his feedback about this from v1 it seems), and
the removal is *pskb assignment to NULL is undoing defensive
programming.
I'm not applying this series.
prev parent reply other threads:[~2019-07-03 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 20:49 [PATCH net-next 0/3 v2] macsec: a few cleanups in the receive path Andreas Steinmetz
2019-07-03 20:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190703.134228.1805959660993963992.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ast@domdv.de \
--cc=netdev@vger.kernel.org \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).