* [PATCH net-next 0/3 v2] macsec: a few cleanups in the receive path
@ 2019-07-02 20:49 Andreas Steinmetz
2019-07-03 20:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Steinmetz @ 2019-07-02 20:49 UTC (permalink / raw)
To: netdev; +Cc: Sabrina Dubroca
This patchset removes some unnecessary code in the receive path of the
macsec driver, and re-indents the error handling after calling
macsec_decrypt to make the post-processing clearer.
This is a combined effort of Sabrina Dubroca <sd@queasysnail.net> and me.
Change in 3/3:
The patch now only moves the IS_ERR(skb) case under the block where
macsec_decrypt() is called, but not the call to macsec_post_decrypt().
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH net-next 0/3 v2] macsec: a few cleanups in the receive path
2019-07-02 20:49 [PATCH net-next 0/3 v2] macsec: a few cleanups in the receive path Andreas Steinmetz
@ 2019-07-03 20:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-07-03 20:42 UTC (permalink / raw)
To: ast; +Cc: netdev, sd
From: Andreas Steinmetz <ast@domdv.de>
Date: Tue, 02 Jul 2019 22:49:54 +0200
> This patchset removes some unnecessary code in the receive path of the
> macsec driver, and re-indents the error handling after calling
> macsec_decrypt to make the post-processing clearer.
>
> This is a combined effort of Sabrina Dubroca <sd@queasysnail.net> and me.
>
> Change in 3/3:
>
> The patch now only moves the IS_ERR(skb) case under the block where
> macsec_decrypt() is called, but not the call to macsec_post_decrypt().
>
I really don't like these changes, especially patches #1 and #2.
Like Willem I don't think you can blindly remove the share check like
this (and you ignored his feedback about this from v1 it seems), and
the removal is *pskb assignment to NULL is undoing defensive
programming.
I'm not applying this series.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-03 20:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-02 20:49 [PATCH net-next 0/3 v2] macsec: a few cleanups in the receive path Andreas Steinmetz
2019-07-03 20:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).