From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 435AFC0650E for ; Wed, 3 Jul 2019 20:42:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AFF621882 for ; Wed, 3 Jul 2019 20:42:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727188AbfGCUma (ORCPT ); Wed, 3 Jul 2019 16:42:30 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:34584 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726821AbfGCUma (ORCPT ); Wed, 3 Jul 2019 16:42:30 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 42EFE1448D92B; Wed, 3 Jul 2019 13:42:29 -0700 (PDT) Date: Wed, 03 Jul 2019 13:42:28 -0700 (PDT) Message-Id: <20190703.134228.1805959660993963992.davem@davemloft.net> To: ast@domdv.de Cc: netdev@vger.kernel.org, sd@queasysnail.net Subject: Re: [PATCH net-next 0/3 v2] macsec: a few cleanups in the receive path From: David Miller In-Reply-To: <7ec44dd08280f0b32dcf18aa35f687fc227c0197.camel@domdv.de> References: <7ec44dd08280f0b32dcf18aa35f687fc227c0197.camel@domdv.de> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 03 Jul 2019 13:42:29 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andreas Steinmetz Date: Tue, 02 Jul 2019 22:49:54 +0200 > This patchset removes some unnecessary code in the receive path of the > macsec driver, and re-indents the error handling after calling > macsec_decrypt to make the post-processing clearer. > > This is a combined effort of Sabrina Dubroca and me. > > Change in 3/3: > > The patch now only moves the IS_ERR(skb) case under the block where > macsec_decrypt() is called, but not the call to macsec_post_decrypt(). > I really don't like these changes, especially patches #1 and #2. Like Willem I don't think you can blindly remove the share check like this (and you ignored his feedback about this from v1 it seems), and the removal is *pskb assignment to NULL is undoing defensive programming. I'm not applying this series.