Netdev List
 help / color / mirror / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Paul Blakey <paulb@mellanox.com>
Cc: Jiri Pirko <jiri@mellanox.com>, Roi Dayan <roid@mellanox.com>,
	Yossi Kuperman <yossiku@mellanox.com>,
	Oz Shlomo <ozsh@mellanox.com>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
	Aaron Conole <aconole@redhat.com>, Zhike Wang <wangzhike@jd.com>,
	Rony Efraim <ronye@mellanox.com>,
	nst-kernel@redhat.com, John Hurley <john.hurley@netronome.com>,
	Simon Horman <simon.horman@netronome.com>,
	Justin Pettit <jpettit@ovn.org>
Subject: Re: [PATCH net-next v3 1/4] net/sched: Introduce action ct
Date: Thu, 4 Jul 2019 14:55:21 -0700	[thread overview]
Message-ID: <20190704145521.29f67ba4@cakuba.netronome.com> (raw)
In-Reply-To: <1562241233-5176-2-git-send-email-paulb@mellanox.com>

On Thu,  4 Jul 2019 14:53:50 +0300, Paul Blakey wrote:
> +static const struct nla_policy ct_policy[TCA_CT_MAX + 1] = {
> +	[TCA_CT_ACTION] = { .type = NLA_U16 },

Please use strict checking in all new policies.

attr 0 must have .strict_start_type set.

  reply	other threads:[~2019-07-04 21:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04 11:53 [PATCH net-next v3 0/4] net/sched: Introduce tc connection tracking Paul Blakey
2019-07-04 11:53 ` [PATCH net-next v3 1/4] net/sched: Introduce action ct Paul Blakey
2019-07-04 21:55   ` Jakub Kicinski [this message]
2019-07-07  6:54     ` Paul Blakey
2019-07-04 11:53 ` [PATCH net-next v3 2/4] net/flow_dissector: add connection tracking dissection Paul Blakey
2019-07-04 11:53 ` [PATCH net-next v3 3/4] net/sched: cls_flower: Add matching on conntrack info Paul Blakey
2019-07-04 11:53 ` [PATCH net-next v3 4/4] tc-tests: Add tc action ct tests Paul Blakey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190704145521.29f67ba4@cakuba.netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=aconole@redhat.com \
    --cc=davem@davemloft.net \
    --cc=jiri@mellanox.com \
    --cc=john.hurley@netronome.com \
    --cc=jpettit@ovn.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nst-kernel@redhat.com \
    --cc=ozsh@mellanox.com \
    --cc=paulb@mellanox.com \
    --cc=roid@mellanox.com \
    --cc=ronye@mellanox.com \
    --cc=simon.horman@netronome.com \
    --cc=wangzhike@jd.com \
    --cc=yossiku@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox