From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA215C0651F for ; Thu, 4 Jul 2019 18:07:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7D8221738 for ; Thu, 4 Jul 2019 18:07:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="RCTGRDZB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727010AbfGDSHS (ORCPT ); Thu, 4 Jul 2019 14:07:18 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:44211 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726978AbfGDSHS (ORCPT ); Thu, 4 Jul 2019 14:07:18 -0400 Received: by mail-qt1-f196.google.com with SMTP id 44so4912867qtg.11 for ; Thu, 04 Jul 2019 11:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=edRK9RyWdDWA8yAro5UhF768SF+PQNMkLfz8Y7BOVeA=; b=RCTGRDZB90xEBxvN/A7efIdulfeZf512hSD10s3xvszz/X0KjXOjv15C3s78OfHAd6 skIUc0U4aywwRoTghByjRBSm12iFktyTQxIfMME7eFhk9SGTHuM1Ru/vfjWca8/J32HE PwXl55oAoh/hvArgJfOx31ldXQjh2uywyaVcv8BTT1FL7gPUr6gVOSsqy/yTfpHwYJIE ZWUVV2OPmM8b2spUTXCAty41hM5L+e0LKA4gPPoofrdNYhDIm2IBs6t8EuAkbhWb7B85 p9sC9771rS1Tom4rNjBAiKm5+h1VnAFchRkSZ7oQRTrNQVgZ4ycrzMQDX5frKKaZf0T8 XpKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=edRK9RyWdDWA8yAro5UhF768SF+PQNMkLfz8Y7BOVeA=; b=RF6l7CN6Oqp9NW4DWmVgZQPxy2B08tVyzaw3ze2K5g6I9pdXBmNICNHTBcNTX3Nr7M kXbUPYredaD7Cj7xXxyXUR0LIfk2TmtBmJrhtf15Rd5h0uSUT06Fs3hdoiz+/NpxVkxE 4bCQc+L0Gc7SmykLPTfi357/6fFLi7Ps8rbMqpuaCc5i0OoRcd5FKP9iwFSjwhWWdJNN EuKzHEzqcnXAqihUVivyenOT+NHTgEMuff2ZvAgI8kJPxM7Lo1ANaA7NQo1HWcI5HIvE OI/IV9ya4QGqv95RH9LhEz0H5UfaNUZHI8skAihqH6eyQZr/tefElBovHiTQlrTmpCsR It6w== X-Gm-Message-State: APjAAAX2+EazbKM41yzBZqc66tZnjOwa6IJcTWMjFbm/bv1kxf+AipaM +OEjxOjAF1ioVLrwZGSfZ1tvlw== X-Google-Smtp-Source: APXvYqwwVoyTUjgrRRi/Bx+hW0epBdCmfFFPtlJu5225jY9Sk0DxpV8YEkMUQEkmedrSL14rtRpM/g== X-Received: by 2002:ac8:689a:: with SMTP id m26mr36411053qtq.192.1562263637216; Thu, 04 Jul 2019 11:07:17 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id j22sm2506688qtp.0.2019.07.04.11.07.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Jul 2019 11:07:16 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hj68a-0000gF-83; Thu, 04 Jul 2019 15:07:16 -0300 Date: Thu, 4 Jul 2019 15:07:16 -0300 From: Jason Gunthorpe To: Leon Romanovsky Cc: Doug Ledford , Leon Romanovsky , RDMA mailing list , Majd Dibbiny , Mark Zhang , Saeed Mahameed , linux-netdev Subject: Re: [PATCH rdma-next v5 11/17] RDMA/netlink: Implement counter dumpit calback Message-ID: <20190704180716.GA2583@ziepe.ca> References: <20190702100246.17382-1-leon@kernel.org> <20190702100246.17382-12-leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190702100246.17382-12-leon@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 02, 2019 at 01:02:40PM +0300, Leon Romanovsky wrote: > diff --git a/include/uapi/rdma/rdma_netlink.h b/include/uapi/rdma/rdma_netlink.h > index 0cb47d23fd86..22c5bc7a82dd 100644 > +++ b/include/uapi/rdma/rdma_netlink.h > @@ -283,6 +283,8 @@ enum rdma_nldev_command { > > RDMA_NLDEV_CMD_STAT_SET, > > + RDMA_NLDEV_CMD_STAT_GET, /* can dump */ > + > RDMA_NLDEV_NUM_OPS > }; > > @@ -496,7 +498,13 @@ enum rdma_nldev_attr { > RDMA_NLDEV_ATTR_STAT_MODE, /* u32 */ > RDMA_NLDEV_ATTR_STAT_RES, /* u32 */ > RDMA_NLDEV_ATTR_STAT_AUTO_MODE_MASK, /* u32 */ > - > + RDMA_NLDEV_ATTR_STAT_COUNTER, /* nested table */ > + RDMA_NLDEV_ATTR_STAT_COUNTER_ENTRY, /* nested table */ > + RDMA_NLDEV_ATTR_STAT_COUNTER_ID, /* u32 */ > + RDMA_NLDEV_ATTR_STAT_HWCOUNTERS, /* nested table */ > + RDMA_NLDEV_ATTR_STAT_HWCOUNTER_ENTRY, /* nested table */ > + RDMA_NLDEV_ATTR_STAT_HWCOUNTER_ENTRY_NAME, /* string */ > + RDMA_NLDEV_ATTR_STAT_HWCOUNTER_ENTRY_VALUE, /* u64 */ > /* > * Information about a chardev. > * CHARDEV_TYPE is the name of the chardev ABI (ie uverbs, umad, etc) This is in the wrong place, needs to be at the end. Jason