From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Joao Pinto <Joao.Pinto@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Jesper Dangaard Brouer <brouer@redhat.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool
Date: Fri, 5 Jul 2019 18:24:53 +0300 [thread overview]
Message-ID: <20190705152453.GA24683@apalos> (raw)
In-Reply-To: <BN8PR12MB32666359FABD7D7E55FE4761D3F50@BN8PR12MB3266.namprd12.prod.outlook.com>
Hi Jose,
On Fri, Jul 05, 2019 at 03:21:16PM +0000, Jose Abreu wrote:
> From: Ilias Apalodimas <ilias.apalodimas@linaro.org>
>
> > I think this look ok for now. One request though, on page_pool_free
>
> Thanks for the review!
>
> > A patch currently under review will slightly change that [1] and [2]
> > Can you defer this a bit till that one gets merged?
> > The only thing you'll have to do is respin this and replace page_pool_free()
> > with page_pool_destroy()
>
> As we are in end of release cycle net-next may close soon so maybe this
> can be merged and I can send a follow-up patch later if that's okay by
> you and David ?
Well ideally we'd like to get the change in before the merge window ourselves,
since we dont want to remove->re-add the same function in stable kernels. If
that doesn't go in i am fine fixing it in the next merge window i guess, since
it offers substantial speedups
Thanks
/Ilias
next prev parent reply other threads:[~2019-07-05 15:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 7:22 [PATCH net-next v3 0/3] net: stmmac: Some improvements and a fix Jose Abreu
2019-07-05 7:22 ` [PATCH net-next v3 1/3] net: stmmac: Implement RX Coalesce Frames setting Jose Abreu
2019-07-05 7:22 ` [PATCH net-next v3 2/3] net: stmmac: Fix descriptors address being in > 32 bits address space Jose Abreu
2019-07-05 7:23 ` [PATCH net-next v3 3/3] net: stmmac: Introducing support for Page Pool Jose Abreu
2019-07-05 13:29 ` Ilias Apalodimas
2019-07-05 15:21 ` Jose Abreu
2019-07-05 15:24 ` Ilias Apalodimas [this message]
2019-07-08 16:08 ` Jose Abreu
2019-07-08 21:15 ` David Miller
2019-07-09 7:23 ` Ilias Apalodimas
2019-07-09 7:38 ` Jose Abreu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190705152453.GA24683@apalos \
--to=ilias.apalodimas@linaro.org \
--cc=Joao.Pinto@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).