From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD7BCC46499 for ; Fri, 5 Jul 2019 15:50:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 878EC2184C for ; Fri, 5 Jul 2019 15:50:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="lFlwULSP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727053AbfGEPuT (ORCPT ); Fri, 5 Jul 2019 11:50:19 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:39152 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726039AbfGEPuT (ORCPT ); Fri, 5 Jul 2019 11:50:19 -0400 Received: by mail-qt1-f196.google.com with SMTP id l9so3321369qtu.6 for ; Fri, 05 Jul 2019 08:50:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=un/QMDgD7xRIOUszwS2wGlz52tslEmbgVJUy/OVF8os=; b=lFlwULSPUbKrvW+iNcCcGnarrV9/iZivr9wvTC5jRF8sye15li8rovk4EI+B5fvE+m hHdQEihBW4yOrOtdwQ2MyCA1DLY1Fk65Frx4r/LXn+fyYT8cu/QxSYF97Z45c/NZ12QK X0RzaAh/Z947F8XK1hD0hpATMQ4gz2O9m+4Ui3HoB9A5FuRcwnuHSlWSKrFkk1sVlaNl Bup/3WXWZaYKW8rgSaAH785jRNXZaCwKZ1wAbCoQoZVsxOev28nd+9/gxqgm3h/4QLTr 4xZ2SsM3Xa9HwGO2uAOdDYlCmtnZZJpbZf5tlvtXNNsjS/lfF6dOsY12g3sjkQmHUr4r kvFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=un/QMDgD7xRIOUszwS2wGlz52tslEmbgVJUy/OVF8os=; b=Mk+GeqSLzg9KFiD3Exy8BHhGDYf7aeMyuyaMgV7lnTVX/J/qW3Ns53HiMr4bUImAiN jIdgtD6iQSIMJ5XF0A6IbCfF8JpUC+Z6hnetbfnT1t3Mlhi1RWQ4jiWId2wsXNaCgGs4 hfZ+sO6aV087wkQ87Sgquopba4NLaC+SphNrnY7aVamJYIcXaxpHJADg1GxFKTHmnXy8 pD4FG+nSN3okilJU0QAJYt7z0qkkLOrKVItQVrpdGDn4nneKMnJj49tTffhC3KnLRp9m DXFFnn8bUROm9+ISZN6Wql0QWxIm5mj8SLidfTSRSUARbjB7W54QENLZ7WdT3PDrFyC8 tryg== X-Gm-Message-State: APjAAAWHkNnS3U39eADGkZyH24mpuKbZ0AQAql7ioibo3kIK+4EzmqsS JoqMpiB+/9rwXlXtZ8aoyUdd8w== X-Google-Smtp-Source: APXvYqzCHlx84qPO9Fcty4PLwQ299M+9+HbG7YB5mC4W2Jwi/Ecm1FWK2FDHnEkXJtDx3bfebkp86w== X-Received: by 2002:ac8:450e:: with SMTP id q14mr477512qtn.132.1562341817828; Fri, 05 Jul 2019 08:50:17 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id q56sm4224593qtq.64.2019.07.05.08.50.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Jul 2019 08:50:17 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hjQTY-0006jc-Vo; Fri, 05 Jul 2019 12:50:16 -0300 Date: Fri, 5 Jul 2019 12:50:16 -0300 From: Jason Gunthorpe To: Leon Romanovsky Cc: Doug Ledford , Leon Romanovsky , RDMA mailing list , Majd Dibbiny , Mark Zhang , Saeed Mahameed , linux-netdev Subject: Re: [PATCH rdma-next v5 00/17] Statistics counter support Message-ID: <20190705155016.GA25864@ziepe.ca> References: <20190702100246.17382-1-leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190702100246.17382-1-leon@kernel.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 02, 2019 at 01:02:29PM +0300, Leon Romanovsky wrote: > From: Leon Romanovsky > > Changelog: > v4 -> v5: > * Patch #6 and #14 - consolidated many counter release functions, > removed mutex lock protection from dealloc_counter() call > and simplified kref_put/kref_get operations. > * Added Saeed's ACK tags. > v3 -> v4: > * Add counter_dealloc() callback function > * Moved to kref implementation > * Fixed lock during spinlock > v2 -> v3: > * We didn't change use of atomics over kref for management of unbind > counter from QP. The reason to it that bind and unbind are non-symmetric > in regards of put and get, so we need to count differently memory > release flows of HW objects (restrack) and SW bind operations. > * Everything else was addressed. > v1 -> v2: > * Rebased to latest rdma-next > v0 -> v1: > * Changed wording of counter comment > * Removed unneeded assignments > * Added extra patch to present global counters > > > Hi, > > This series from Mark provides dynamic statistics infrastructure. > He uses netlink interface to configure and retrieve those counters. > > This infrastructure allows to users monitor various objects by binding > to them counters. As the beginning, we used QP object as target for > those counters, but future patches will include ODP MR information too. > > Two binding modes are supported: > - Auto: This allows a user to build automatic set of objects to a counter > according to common criteria. For example in a per-type scheme, where in > one process all QPs with same QP type are bound automatically to a single > counter. > - Manual: This allows a user to manually bind objects on a counter. > > Those two modes are mutual-exclusive with separation between processes, > objects created by different processes cannot be bound to a same counter. > > For objects which don't support counter binding, we will return > pre-allocated counters. > > $ rdma statistic qp set link mlx5_2/1 auto type on > $ rdma statistic qp set link mlx5_2/1 auto off > $ rdma statistic qp bind link mlx5_2/1 lqpn 178 > $ rdma statistic qp unbind link mlx5_2/1 cntn 4 lqpn 178 > $ rdma statistic show > $ rdma statistic qp mode > > Thanks > > > Mark Zhang (17): > net/mlx5: Add rts2rts_qp_counters_set_id field in hca cap > RDMA/restrack: Introduce statistic counter > RDMA/restrack: Add an API to attach a task to a resource > RDMA/restrack: Make is_visible_in_pid_ns() as an API > RDMA/counter: Add set/clear per-port auto mode support > RDMA/counter: Add "auto" configuration mode support > IB/mlx5: Support set qp counter > IB/mlx5: Add counter set id as a parameter for > mlx5_ib_query_q_counters() > IB/mlx5: Support statistic q counter configuration > RDMA/nldev: Allow counter auto mode configration through RDMA netlink > RDMA/netlink: Implement counter dumpit calback > IB/mlx5: Add counter_alloc_stats() and counter_update_stats() support > RDMA/core: Get sum value of all counters when perform a sysfs stat > read > RDMA/counter: Allow manual mode configuration support > RDMA/nldev: Allow counter manual mode configration through RDMA > netlink > RDMA/nldev: Allow get counter mode through RDMA netlink > RDMA/nldev: Allow get default counter statistics through RDMA netlink Okay, applied to for-next Thanks, Jason