From: David Miller <davem@davemloft.net>
To: adobriyan@gmail.com
Cc: viro@zeniv.linux.org.uk, netdev@vger.kernel.org,
Per.Hallsmark@windriver.com
Subject: Re: [PATCH 1/2] proc: revalidate directories created with proc_net_mkdir()
Date: Sun, 07 Jul 2019 12:51:49 -0700 (PDT) [thread overview]
Message-ID: <20190707.125149.1162742277762067187.davem@davemloft.net> (raw)
In-Reply-To: <20190707080351.GA6236@avx2>
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Sun, 7 Jul 2019 11:03:51 +0300
> On Sun, Jul 07, 2019 at 02:03:20AM +0100, Al Viro wrote:
>> On Sat, Jul 06, 2019 at 07:52:02PM +0300, Alexey Dobriyan wrote:
>> > +struct proc_dir_entry *_proc_mkdir(const char *name, umode_t mode,
>> > + struct proc_dir_entry **parent, void *data)
>>
>> Two underscores, please...
>
> Second underscore is more typing, I never understood it.
Canonicalness is not about understanding, it's about being consistent
with the rest of the tree.
Just do it please...
prev parent reply other threads:[~2019-07-07 19:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-06 16:52 [PATCH 1/2] proc: revalidate directories created with proc_net_mkdir() Alexey Dobriyan
2019-07-07 1:03 ` Al Viro
2019-07-07 8:03 ` Alexey Dobriyan
2019-07-07 19:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190707.125149.1162742277762067187.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Per.Hallsmark@windriver.com \
--cc=adobriyan@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).