From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F40CC606D1 for ; Mon, 8 Jul 2019 22:23:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18F69216C4 for ; Mon, 8 Jul 2019 22:23:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726369AbfGHWXy (ORCPT ); Mon, 8 Jul 2019 18:23:54 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:59526 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbfGHWXx (ORCPT ); Mon, 8 Jul 2019 18:23:53 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 71B20126B590B; Mon, 8 Jul 2019 15:23:53 -0700 (PDT) Date: Mon, 08 Jul 2019 15:23:52 -0700 (PDT) Message-Id: <20190708.152352.710464914281100209.davem@davemloft.net> To: yanjun.zhu@oracle.com Cc: netdev@vger.kernel.org Subject: Re: [PATCH 0/2] forcedeth: recv cache support From: David Miller In-Reply-To: <1562307568-21549-1-git-send-email-yanjun.zhu@oracle.com> References: <1562307568-21549-1-git-send-email-yanjun.zhu@oracle.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 08 Jul 2019 15:23:53 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Zhu Yanjun Date: Fri, 5 Jul 2019 02:19:26 -0400 > This recv cache is to make NIC work steadily when the system memory is > not enough. The system is supposed to hold onto enough atomic memory to absorb all reasonable situations like this. If anything a solution to this problem belongs generically somewhere, not in a driver. And furthermore looping over an allocation attempt with a delay is strongly discouraged.