From: David Miller <davem@davemloft.net>
To: debrabander@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] selftests: txring_overwrite: fix incorrect test of mmap() return value
Date: Mon, 08 Jul 2019 15:40:34 -0700 (PDT) [thread overview]
Message-ID: <20190708.154034.2114427019293786374.davem@davemloft.net> (raw)
In-Reply-To: <1562326994-4569-1-git-send-email-debrabander@gmail.com>
From: Frank de Brabander <debrabander@gmail.com>
Date: Fri, 5 Jul 2019 13:43:14 +0200
> If mmap() fails it returns MAP_FAILED, which is defined as ((void *) -1).
> The current if-statement incorrectly tests if *ring is NULL.
>
> Signed-off-by: Frank de Brabander <debrabander@gmail.com>
Applied with fixes tag added and queued up for -stable, thanks.
prev parent reply other threads:[~2019-07-08 22:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 11:43 [PATCH] selftests: txring_overwrite: fix incorrect test of mmap() return value Frank de Brabander
2019-07-05 19:55 ` Willem de Bruijn
2019-07-08 22:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190708.154034.2114427019293786374.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=debrabander@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).