From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 035B0C606CF for ; Mon, 8 Jul 2019 22:40:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7C2921479 for ; Mon, 8 Jul 2019 22:40:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728599AbfGHWkg (ORCPT ); Mon, 8 Jul 2019 18:40:36 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:59686 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728510AbfGHWkf (ORCPT ); Mon, 8 Jul 2019 18:40:35 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 3197212D6C874; Mon, 8 Jul 2019 15:40:35 -0700 (PDT) Date: Mon, 08 Jul 2019 15:40:34 -0700 (PDT) Message-Id: <20190708.154034.2114427019293786374.davem@davemloft.net> To: debrabander@gmail.com Cc: netdev@vger.kernel.org Subject: Re: [PATCH] selftests: txring_overwrite: fix incorrect test of mmap() return value From: David Miller In-Reply-To: <1562326994-4569-1-git-send-email-debrabander@gmail.com> References: <1562326994-4569-1-git-send-email-debrabander@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 08 Jul 2019 15:40:35 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Frank de Brabander Date: Fri, 5 Jul 2019 13:43:14 +0200 > If mmap() fails it returns MAP_FAILED, which is defined as ((void *) -1). > The current if-statement incorrectly tests if *ring is NULL. > > Signed-off-by: Frank de Brabander Applied with fixes tag added and queued up for -stable, thanks.