From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22351C606CF for ; Tue, 9 Jul 2019 02:25:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 028C82166E for ; Tue, 9 Jul 2019 02:25:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726391AbfGICZy (ORCPT ); Mon, 8 Jul 2019 22:25:54 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:33756 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726072AbfGICZy (ORCPT ); Mon, 8 Jul 2019 22:25:54 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6DE50133E9740; Mon, 8 Jul 2019 19:25:53 -0700 (PDT) Date: Mon, 08 Jul 2019 19:25:52 -0700 (PDT) Message-Id: <20190708.192552.833537119648669033.davem@davemloft.net> To: viro@zeniv.linux.org.uk Cc: netdev@vger.kernel.org Subject: Re: [PATCH] sockfs: switch to ->free_inode() From: David Miller In-Reply-To: <20190705191322.GK17978@ZenIV.linux.org.uk> References: <20190705191322.GK17978@ZenIV.linux.org.uk> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 08 Jul 2019 19:25:53 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Al Viro Date: Fri, 5 Jul 2019 20:13:22 +0100 > we do have an RCU-delayed part there already (freeing the wq), > so it's not like the pipe situation; moreover, it might be > worth considering coallocating wq with the rest of struct sock_alloc. > ->sk_wq in struct sock would remain a pointer as it is, but > the object it normally points to would be coallocated with > struct socket... > > Signed-off-by: Al Viro Applied.