From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Cx4R=VG=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id A1B5AC606CF
	for <netdev@archiver.kernel.org>; Tue,  9 Jul 2019 02:26:00 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 805D92166E
	for <netdev@archiver.kernel.org>; Tue,  9 Jul 2019 02:26:00 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726780AbfGICZ7 (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 8 Jul 2019 22:25:59 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:33762 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725886AbfGICZ7 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 8 Jul 2019 22:25:59 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 4BF1E133E9760;
        Mon,  8 Jul 2019 19:25:59 -0700 (PDT)
Date:   Mon, 08 Jul 2019 19:25:58 -0700 (PDT)
Message-Id: <20190708.192558.1304552003355538760.davem@davemloft.net>
To:     viro@zeniv.linux.org.uk
Cc:     netdev@vger.kernel.org
Subject: Re: [PATCH] coallocate socket_wq with socket itself
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190705191416.GL17978@ZenIV.linux.org.uk>
References: <20190705191322.GK17978@ZenIV.linux.org.uk>
        <20190705191416.GL17978@ZenIV.linux.org.uk>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 08 Jul 2019 19:25:59 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Al Viro <viro@zeniv.linux.org.uk>
Date: Fri, 5 Jul 2019 20:14:16 +0100

> socket->wq is assign-once, set when we are initializing both
> struct socket it's in and struct socket_wq it points to.  As the
> matter of fact, the only reason for separate allocation was the
> ability to RCU-delay freeing of socket_wq.  RCU-delaying the
> freeing of socket itself gets rid of that need, so we can just
> fold struct socket_wq into the end of struct socket and simplify
> the life both for sock_alloc_inode() (one allocation instead of
> two) and for tun/tap oddballs, where we used to embed struct socket
> and struct socket_wq into the same structure (now - embedding just
> the struct socket).
> 
> Note that reference to struct socket_wq in struct sock does remain
> a reference - that's unchanged.
> 
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

Applied.