From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C400AC606B0 for ; Tue, 9 Jul 2019 02:39:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9CE7F2086D for ; Tue, 9 Jul 2019 02:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726658AbfGICjE (ORCPT ); Mon, 8 Jul 2019 22:39:04 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:33926 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725941AbfGICjE (ORCPT ); Mon, 8 Jul 2019 22:39:04 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 15971133E976D; Mon, 8 Jul 2019 19:39:04 -0700 (PDT) Date: Mon, 08 Jul 2019 19:39:03 -0700 (PDT) Message-Id: <20190708.193903.1733587425759708535.davem@davemloft.net> To: willemdebruijn.kernel@gmail.com Cc: netdev@vger.kernel.org, linyunsheng@huawei.com, willemb@google.com Subject: Re: [PATCH net-next v2] skbuff: increase verbosity when dumping skb data From: David Miller In-Reply-To: <20190707095155.58578-1-willemdebruijn.kernel@gmail.com> References: <20190707095155.58578-1-willemdebruijn.kernel@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 08 Jul 2019 19:39:04 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Willem de Bruijn Date: Sun, 7 Jul 2019 05:51:55 -0400 > From: Willem de Bruijn > > skb_warn_bad_offload and netdev_rx_csum_fault trigger on hard to debug > issues. Dump more state and the header. > > Optionally dump the entire packet and linear segment. This is required > to debug checksum bugs that may include bytes past skb_tail_pointer(). > > Both call sites call this function inside a net_ratelimit() block. > Limit full packet log further to a hard limit of can_dump_full (5). > > Based on an earlier patch by Cong Wang, see link below. > > Changes v1 -> v2 > - dump frag_list only on full_pkt > > Link: https://patchwork.ozlabs.org/patch/1000841/ > Signed-off-by: Willem de Bruijn Nice to finally have this, applied.