From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 299E4C606CD for ; Mon, 8 Jul 2019 20:01:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0237D2064B for ; Mon, 8 Jul 2019 20:01:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="CVOcYgSE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404817AbfGHUBj (ORCPT ); Mon, 8 Jul 2019 16:01:39 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:34881 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728823AbfGHUBj (ORCPT ); Mon, 8 Jul 2019 16:01:39 -0400 Received: by mail-pf1-f193.google.com with SMTP id u14so6923499pfn.2 for ; Mon, 08 Jul 2019 13:01:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+rS3r5/o5WlglKViT05ZfPqB6A1XK/bfTpeSIbtHg0Q=; b=CVOcYgSEvh1Iyt/5ekj6VuLbZ/qdh9vrCDeeWY5d34h1vdMhsbs3BCYEHu95y6UvMM 7Z70VYRicybfXnwBIUHXnFSffN53pGjH4NJdHVy3khRhRSkh/u4e774D/T/dn4OLilrg YeZsbuL8rp3AIbIebFwZJBZ9IiJXCa+vbIkNE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+rS3r5/o5WlglKViT05ZfPqB6A1XK/bfTpeSIbtHg0Q=; b=Kl6jeymbuI/GlVxP/uA0dIDnsYyH0whx+aqUHnb/RucAO95BNz1qC6UV28eAAxpvUg Q0TdEejbsM0BuMjJJlSVpbMrUyVdFVXaWv0vnJcfrUcvRkWbDC0bifxuPqjYC7yeqcz1 Sr9ROyCb7CG9kNJH8JkSHmHeRcnJaA4p3ds7sPc1xTM0/mWG8rRFUF97/G1h1U0JquTo XOz8BYy/Z2da9LKdX9e0xJXTwwX33QFIsO0Ho2stnzRGn8oqO/8LCXoPn2HCQVm9bcnP xEU6T29B4d9TzYvGXmpyV+fw3JGxRzGP2gxlsbcJrTgaq4fMtIBwRQmf0VWWqs48Mmex YELA== X-Gm-Message-State: APjAAAXeROMu9r1jtdwcyc3EHUOcovee13d9/jlmQ2PjKr71rhYJMwxs VpQ+UtL+fWEKsLNioaK8tPxsog== X-Google-Smtp-Source: APXvYqxsXmL8H3YlaNJHrM80DDPyuqBUBVzPdrdzzDi2u7Tph0fpyS7VUV+Z2JjPq13R9E7qjd5tfA== X-Received: by 2002:a63:b904:: with SMTP id z4mr25368975pge.388.1562616098656; Mon, 08 Jul 2019 13:01:38 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id l124sm24507761pgl.54.2019.07.08.13.01.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Jul 2019 13:01:38 -0700 (PDT) Date: Mon, 8 Jul 2019 13:01:36 -0700 From: Matthias Kaehlcke To: Andrew Lunn Cc: "David S . Miller" , Rob Herring , Mark Rutland , Florian Fainelli , Heiner Kallweit , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Douglas Anderson Subject: Re: [PATCH v3 1/7] dt-bindings: net: Add bindings for Realtek PHYs Message-ID: <20190708200136.GM250418@google.com> References: <20190708192459.187984-1-mka@chromium.org> <20190708192459.187984-2-mka@chromium.org> <20190708194615.GH9027@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190708194615.GH9027@lunn.ch> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jul 08, 2019 at 09:46:15PM +0200, Andrew Lunn wrote: > On Mon, Jul 08, 2019 at 12:24:53PM -0700, Matthias Kaehlcke wrote: > > Add the 'realtek,eee-led-mode-disable' property to disable EEE > > LED mode on Realtek PHYs that support it. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > TODO: adapt PHY core to deal with optional compatible strings > > Yes. Does this even work at the moment? I would expect > of_mdiobus_child_is_phy() to return false, indicating the device is > not actually a PHY. Indeed, it currently doesn't work atm. I found that removing the check for dev->of_node in of_mdiobus_link_mdiodev() helps, but I imagine doing (only) this might have undesired side-effects.