From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA866C73C46 for ; Tue, 9 Jul 2019 19:03:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 962172082A for ; Tue, 9 Jul 2019 19:03:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729050AbfGITDm (ORCPT ); Tue, 9 Jul 2019 15:03:42 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44050 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727942AbfGITDm (ORCPT ); Tue, 9 Jul 2019 15:03:42 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B3E55140163B1; Tue, 9 Jul 2019 12:03:41 -0700 (PDT) Date: Tue, 09 Jul 2019 12:03:36 -0700 (PDT) Message-Id: <20190709.120336.1987683013901804676.davem@davemloft.net> To: jakub.kicinski@netronome.com Cc: jiri@resnulli.us, parav@mellanox.com, netdev@vger.kernel.org, jiri@mellanox.com, saeedm@mellanox.com Subject: Re: [PATCH net-next v6 0/5] devlink: Introduce PCI PF, VF ports and attributes From: David Miller In-Reply-To: <20190709112058.7ffe61d3@cakuba.netronome.com> References: <20190708224012.0280846c@cakuba.netronome.com> <20190709061711.GH2282@nanopsycho.orion> <20190709112058.7ffe61d3@cakuba.netronome.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 09 Jul 2019 12:03:41 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jakub Kicinski Date: Tue, 9 Jul 2019 11:20:58 -0700 > On Tue, 9 Jul 2019 08:17:11 +0200, Jiri Pirko wrote: >> >But I'll leave it to Jiri and Dave to decide if its worth a respin :) >> >Functionally I think this is okay. >> >> I'm happy with the set as it is right now. > > To be clear, I am happy enough as well. Hence the review tag. Series applied, thanks everyone. >> Anyway, if you want your concerns to be addresses, you should write >> them to the appropriate code. This list is hard to follow. > > Sorry, I was trying to be concise. Jiri et al., if Jakub put forth the time and effort to make the list and give you feedback you can put forth the effort to go through the list and address his feedback with follow-up patches. You cannot dictate how people give feedback to your changes, thank you.