Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: paulb@mellanox.com
Cc: jiri@mellanox.com, roid@mellanox.com, yossiku@mellanox.com,
	ozsh@mellanox.com, marcelo.leitner@gmail.com,
	netdev@vger.kernel.org, aconole@redhat.com, wangzhike@jd.com,
	ronye@mellanox.com, nst-kernel@redhat.com,
	john.hurley@netronome.com, simon.horman@netronome.com,
	jpettit@ovn.org
Subject: Re: [PATCH net-next v6 0/4] net/sched: Introduce tc connection tracking
Date: Tue, 09 Jul 2019 12:14:02 -0700 (PDT)	[thread overview]
Message-ID: <20190709.121402.1804664264408465946.davem@davemloft.net> (raw)
In-Reply-To: <1562657451-20819-1-git-send-email-paulb@mellanox.com>

From: Paul Blakey <paulb@mellanox.com>
Date: Tue,  9 Jul 2019 10:30:47 +0300

> This patch series add connection tracking capabilities in tc sw datapath.
> It does so via a new tc action, called act_ct, and new tc flower classifier matching
> on conntrack state, mark and label.
 ...

Ok, I applied this, but two things:

1) You owe Cong Wang an explanation, a real detailed one, about the L2
   vs L3 design of this feature.  I did not see you address his feedback,
   but if you did I apologize.

2) Because the MPLS changes went in first, TCA_ID_CT ended up in a
   different spot in the enumeration and therefore the value is
   different.

Thanks.

  parent reply	other threads:[~2019-07-09 19:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-09  7:30 [PATCH net-next v6 0/4] net/sched: Introduce tc connection tracking Paul Blakey
2019-07-09  7:30 ` [PATCH net-next v6 1/4] net/sched: Introduce action ct Paul Blakey
2019-07-09  7:30 ` [PATCH net-next v6 2/4] net/flow_dissector: add connection tracking dissection Paul Blakey
2019-07-09  7:30 ` [PATCH net-next v6 3/4] net/sched: cls_flower: Add matching on conntrack info Paul Blakey
2019-07-09  7:30 ` [PATCH net-next v6 4/4] tc-tests: Add tc action ct tests Paul Blakey
2019-07-09 19:14 ` David Miller [this message]
2019-07-11  7:12   ` [PATCH net-next v6 0/4] net/sched: Introduce tc connection tracking Paul Blakey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190709.121402.1804664264408465946.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=aconole@redhat.com \
    --cc=jiri@mellanox.com \
    --cc=john.hurley@netronome.com \
    --cc=jpettit@ovn.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nst-kernel@redhat.com \
    --cc=ozsh@mellanox.com \
    --cc=paulb@mellanox.com \
    --cc=roid@mellanox.com \
    --cc=ronye@mellanox.com \
    --cc=simon.horman@netronome.com \
    --cc=wangzhike@jd.com \
    --cc=yossiku@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox