From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87194C73C53 for ; Tue, 9 Jul 2019 20:20:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6E72321537 for ; Tue, 9 Jul 2019 20:20:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729703AbfGIUUV (ORCPT ); Tue, 9 Jul 2019 16:20:21 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:44982 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727241AbfGIUUU (ORCPT ); Tue, 9 Jul 2019 16:20:20 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 0769E140F881F; Tue, 9 Jul 2019 13:20:19 -0700 (PDT) Date: Tue, 09 Jul 2019 13:20:19 -0700 (PDT) Message-Id: <20190709.132019.1388902487563801440.davem@davemloft.net> To: arnd@arndb.de Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, paweldembicki@gmail.com, linus.walleij@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [net-next] net: dsa: vsc73xx: fix NET_DSA and OF dependencies From: David Miller In-Reply-To: <20190709185626.3275510-1-arnd@arndb.de> References: <20190709185626.3275510-1-arnd@arndb.de> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 09 Jul 2019 13:20:20 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Arnd Bergmann Date: Tue, 9 Jul 2019 20:55:55 +0200 > The restructuring of the driver got the dependencies wrong: without > CONFIG_NET_DSA we get this build failure: > > WARNING: unmet direct dependencies detected for NET_DSA_VITESSE_VSC73XX > Depends on [n]: NETDEVICES [=y] && HAVE_NET_DSA [=y] && OF [=y] && NET_DSA [=n] > Selected by [m]: > - NET_DSA_VITESSE_VSC73XX_PLATFORM [=m] && NETDEVICES [=y] && HAVE_NET_DSA [=y] && HAS_IOMEM [=y] > > ERROR: "dsa_unregister_switch" [drivers/net/dsa/vitesse-vsc73xx-core.ko] undefined! > ERROR: "dsa_switch_alloc" [drivers/net/dsa/vitesse-vsc73xx-core.ko] undefined! > ERROR: "dsa_register_switch" [drivers/net/dsa/vitesse-vsc73xx-core.ko] undefined! > > Add the appropriate dependencies. > > Fixes: 95711cd5f0b4 ("net: dsa: vsc73xx: Split vsc73xx driver") > Signed-off-by: Arnd Bergmann Applied, thanks Arnd.