From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 668C9C606B0 for ; Tue, 9 Jul 2019 06:52:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 440FC21537 for ; Tue, 9 Jul 2019 06:52:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725974AbfGIGw2 (ORCPT ); Tue, 9 Jul 2019 02:52:28 -0400 Received: from mx2.suse.de ([195.135.220.15]:35916 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725818AbfGIGw2 (ORCPT ); Tue, 9 Jul 2019 02:52:28 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id ECAA5AC90; Tue, 9 Jul 2019 06:52:26 +0000 (UTC) Date: Tue, 9 Jul 2019 15:52:20 +0900 From: Benjamin Poirier To: Manish Chopra Cc: GR-Linux-NIC-Dev , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next 11/16] qlge: Remove qlge_bq.len & size Message-ID: <20190709065220.GA990@f1> References: <20190617074858.32467-1-bpoirier@suse.com> <20190617074858.32467-11-bpoirier@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2019/06/27 10:47, Manish Chopra wrote: > > > > - for (i = 0; i < qdev->rx_ring_count; i++) { > > + for (i = 0; i < qdev->rss_ring_count; i++) { > > struct rx_ring *rx_ring = &qdev->rx_ring[i]; > > > > - if (rx_ring->lbq.queue) > > - ql_free_lbq_buffers(qdev, rx_ring); > > - if (rx_ring->sbq.queue) > > - ql_free_sbq_buffers(qdev, rx_ring); > > + ql_free_lbq_buffers(qdev, rx_ring); > > + ql_free_sbq_buffers(qdev, rx_ring); > > } > > } > > > > Seems irrelevant change as per what this patch is supposed to do exactly. Sure, I've removed that hunk.