From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4430FC73C46 for ; Tue, 9 Jul 2019 13:39:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D8A120861 for ; Tue, 9 Jul 2019 13:39:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="low1tkX+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727034AbfGINjq (ORCPT ); Tue, 9 Jul 2019 09:39:46 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:42037 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726345AbfGINjq (ORCPT ); Tue, 9 Jul 2019 09:39:46 -0400 Received: by mail-wr1-f66.google.com with SMTP id a10so19990000wrp.9 for ; Tue, 09 Jul 2019 06:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=apoOMffNJoQn70AP+vwaQWCqZ67b11ZTTTPNPF0zncc=; b=low1tkX+u0lmbS53jGQMF39lCRHPF4OmP0atVBomBggFXnzvLKyRf94mZxIe074Pcm YsVhjy3HsTU79H83cps/H9wRxNdKJgTMhWQsyii4YVxz61gBKdPqu6Ntjvf/3cz854r9 iqY6UJycGQQ2Q5b+cC9Cw2Mw+QT5HUNSg590fCqW3FDDdhJ6EV0aBpbkh3VONpJOgDY9 v/VVok38LDTXBXy1lkMMSUYhKDE/9Ungavt6a4DPdqUT5xrnFIH3s5OeFekiPl/jmBr0 9xVdMuuau0ikX90ueNGoO0NVnRJIfePLA+wWcjGYNpsox/bomBnjmEMOLWScBVrTEBEj My8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=apoOMffNJoQn70AP+vwaQWCqZ67b11ZTTTPNPF0zncc=; b=KLZJfpvZDuqrtLTtIra5A5L3HR1AievoYRXT1NDcgW8RzBP1gJ/8I8qjdnNyACXv9f pWy4tqDRrWMBGiT/ThYwvqRpa+KeYxTEkNBkFrC9gLxxwRRiG9alddJ4j0RqU26jiPCN b/H2io7qtsRm7iPYMN55jRSXnswq+dT+XYVdyQiVM9RWIhFpe+WAomqbsFCsidTK926C MHaQIMxQw7TkzrUSg9GI9F7ZsuKKlxmD5doMG0f4YuGeSgiIDsHlZqW09NvcE6TlSBJG R9bysv5goQgpN8rE1VL9/Varjni9e2e15Wgs70OH18tMpQ8jDGy25oO6b2NDAwMhRhb9 QJmQ== X-Gm-Message-State: APjAAAWyM6ypW2HJ2GOzwpUk1Z6seU+XSeSRWgK9MS1iHudcgzljO/zm h5RU1FtYvOMf5y9SLTlXSgSYdA== X-Google-Smtp-Source: APXvYqzx7x4PaqGGI3lQwjrwx1jljBVsRO2D7YzozT/qbBkMF/u153y1W2UIg60XDmesJBx4LOE/7Q== X-Received: by 2002:adf:f646:: with SMTP id x6mr21117021wrp.18.1562679584114; Tue, 09 Jul 2019 06:39:44 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id z25sm3598235wmf.38.2019.07.09.06.39.43 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 09 Jul 2019 06:39:43 -0700 (PDT) Date: Tue, 9 Jul 2019 15:39:43 +0200 From: Jiri Pirko To: Pablo Neira Ayuso Cc: netdev@vger.kernel.org, davem@davemloft.net, thomas.lendacky@amd.com, f.fainelli@gmail.com, ariel.elior@cavium.com, michael.chan@broadcom.com, madalin.bucur@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, tariqt@mellanox.com, saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, peppe.cavallaro@st.com, grygorii.strashko@ti.com, andrew@lunn.ch, vivien.didelot@gmail.com, alexandre.torgue@st.com, joabreu@synopsys.com, linux-net-drivers@solarflare.com, ogerlitz@mellanox.com, Manish.Chopra@cavium.com, marcelo.leitner@gmail.com, mkubecek@suse.cz, venkatkumar.duvvuru@broadcom.com, maxime.chevallier@bootlin.com, cphealy@gmail.com, netfilter-devel@vger.kernel.org Subject: Re: [PATCH net-next,v3 10/11] net: flow_offload: add flow_block_cb_is_busy() and use it Message-ID: <20190709133943.GC2301@nanopsycho.orion> References: <20190708160614.2226-1-pablo@netfilter.org> <20190708160614.2226-11-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190708160614.2226-11-pablo@netfilter.org> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Mon, Jul 08, 2019 at 06:06:12PM CEST, pablo@netfilter.org wrote: [...] >+bool flow_block_cb_is_busy(tc_setup_cb_t *cb, void *cb_ident, There should be another patch before this one renaming tc_setup_cb_t and ndo_setup_tc. This is not TC specific anymore now, it might confuse the reader. [...]