From: Stephen Hemminger <stephen@networkplumber.org>
To: David Ahern <dsahern@gmail.com>
Cc: John Hurley <john.hurley@netronome.com>,
netdev@vger.kernel.org, davem@davemloft.net, jiri@mellanox.com,
xiyou.wangcong@gmail.com, willemdebruijn.kernel@gmail.com,
simon.horman@netronome.com, jakub.kicinski@netronome.com,
oss-drivers@netronome.com
Subject: Re: [PATCH iproute2-next 2/3] tc: add mpls actions
Date: Tue, 9 Jul 2019 14:05:05 -0700 [thread overview]
Message-ID: <20190709140505.75efc84b@hermes.lan> (raw)
In-Reply-To: <f202a7ef-909b-1c0c-2a75-10d989b4923f@gmail.com>
On Tue, 9 Jul 2019 14:36:34 -0600
David Ahern <dsahern@gmail.com> wrote:
> On 7/9/19 11:00 AM, Stephen Hemminger wrote:
> > On Tue, 9 Jul 2019 16:59:31 +0100
> > John Hurley <john.hurley@netronome.com> wrote:
> >
> >> if (!tb[TCA_MPLS_PARMS]) {
> >> + print_string(PRINT_FP, NULL, "%s", "[NULL mpls parameters]");
> >
> > This is an error message please just use fprintf(stderr instead
> >
>
> skbedit, nat as 2 examples (and the only 2 I checked) do the print_string.
Thanks I will fix those.
next prev parent reply other threads:[~2019-07-09 21:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 15:59 [PATCH iproute2-next 0/3] add interface to TC MPLS actions John Hurley
2019-07-09 15:59 ` [PATCH iproute2-next 1/3] lib: add mpls_uc and mpls_mc as link layer protocol names John Hurley
2019-07-09 15:59 ` [PATCH iproute2-next 2/3] tc: add mpls actions John Hurley
2019-07-09 17:00 ` Stephen Hemminger
2019-07-09 20:36 ` David Ahern
2019-07-09 21:05 ` Stephen Hemminger [this message]
2019-07-09 20:39 ` David Ahern
2019-07-09 15:59 ` [PATCH iproute2-next 3/3] man: update man pages for TC MPLS actions John Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709140505.75efc84b@hermes.lan \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@mellanox.com \
--cc=john.hurley@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
--cc=simon.horman@netronome.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).