From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 335E1C73C6D for ; Wed, 10 Jul 2019 05:26:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B7742083D for ; Wed, 10 Jul 2019 05:26:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562736367; bh=Kys1gcysM72zsgKWsn+6EdxEqfmUCE6rXKMr0l49izY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=XopbFhvdnTHyJh/bnxgxUE6NERvjEEwfTbV1zRq5F3FinqWewj/aktTrE8Pre7skk eSE97PV4eRSzjFw7DpV09AxTDrg8zlpzdeAdraBIabvqDVpQJeqvAGYexZkH9mp8fi hJAt+5QyiC9wmE7bFveSTTb4/dcWezd0ce6KAH7M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726975AbfGJF0F (ORCPT ); Wed, 10 Jul 2019 01:26:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:48916 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725932AbfGJF0F (ORCPT ); Wed, 10 Jul 2019 01:26:05 -0400 Received: from localhost (unknown [37.142.3.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8895220665; Wed, 10 Jul 2019 05:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562736364; bh=Kys1gcysM72zsgKWsn+6EdxEqfmUCE6rXKMr0l49izY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vuclRuTSOIwiTwOfJZjAI6LaZrLfp//U3Jzw9DHJCiE2ursM0S6KnDRhf00sxAXfk 9nBi/J+82Oudcmy+mqSsPUJOzwjewWMNiD68CN6ikbjj5nrkz9TrmnpH/SuYf1iNKX mQgxRkvm2C4o/IFULVBrrbFlAe2u+fi0uElkmZ20= Date: Wed, 10 Jul 2019 08:25:59 +0300 From: Leon Romanovsky To: Henry Orosco Cc: Jason Gunthorpe , "Saleem, Shiraz" , "Kirsher, Jeffrey T" , "dledford@redhat.com" , "davem@davemloft.net" , "Ismail, Mustafa" , "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , "nhorman@redhat.com" , "sassmann@redhat.com" , "poswald@suse.com" , "Ertman, David M" Subject: Re: [rdma 14/16] RDMA/irdma: Add ABI definitions Message-ID: <20190710052559.GD7034@mtr-leonro.mtl.com> References: <20190704021259.15489-1-jeffrey.t.kirsher@intel.com> <20190704021259.15489-16-jeffrey.t.kirsher@intel.com> <20190704074021.GH4727@mtr-leonro.mtl.com> <20190704121933.GD3401@mellanox.com> <9DD61F30A802C4429A01CA4200E302A7A684DAAA@fmsmsx124.amr.corp.intel.com> <20190705171650.GI31525@mellanox.com> <9DD61F30A802C4429A01CA4200E302A7A68512AA@fmsmsx124.amr.corp.intel.com> <20190708141336.GF23966@mellanox.com> <20190709205613.GA7440@horosco-MOBL2.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190709205613.GA7440@horosco-MOBL2.amr.corp.intel.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 09, 2019 at 03:56:13PM -0500, Henry Orosco wrote: > On Mon, Jul 08, 2019 at 02:13:39PM +0000, Jason Gunthorpe wrote: > > On Sat, Jul 06, 2019 at 04:15:20PM +0000, Saleem, Shiraz wrote: > > > > Subject: Re: [rdma 14/16] RDMA/irdma: Add ABI definitions > > > > > > > > On Fri, Jul 05, 2019 at 04:42:19PM +0000, Saleem, Shiraz wrote: > > > > > > Subject: Re: [rdma 14/16] RDMA/irdma: Add ABI definitions > > > > > > > > > > > > On Thu, Jul 04, 2019 at 10:40:21AM +0300, Leon Romanovsky wrote: > > > > > > > On Wed, Jul 03, 2019 at 07:12:57PM -0700, Jeff Kirsher wrote: > > > > > > > > From: Mustafa Ismail > > > > > > > > > > > > > > > > Add ABI definitions for irdma. > > > > > > > > > > > > > > > > Signed-off-by: Mustafa Ismail > > > > > > > > Signed-off-by: Shiraz Saleem > > > > > > > > include/uapi/rdma/irdma-abi.h | 130 > > > > > > > > ++++++++++++++++++++++++++++++++++ > > > > > > > > 1 file changed, 130 insertions(+) create mode 100644 > > > > > > > > include/uapi/rdma/irdma-abi.h > > > > > > > > > > > > > > > > diff --git a/include/uapi/rdma/irdma-abi.h > > > > > > > > b/include/uapi/rdma/irdma-abi.h new file mode 100644 index > > > > > > > > 000000000000..bdfbda4c829e > > > > > > > > +++ b/include/uapi/rdma/irdma-abi.h > > > > > > > > @@ -0,0 +1,130 @@ > > > > > > > > +/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */ > > > > > > > > +/* Copyright (c) 2006 - 2019 Intel Corporation. All rights reserved. > > > > > > > > + * Copyright (c) 2005 Topspin Communications. All rights reserved. > > > > > > > > + * Copyright (c) 2005 Cisco Systems. All rights reserved. > > > > > > > > + * Copyright (c) 2005 Open Grid Computing, Inc. All rights reserved. > > > > > > > > + */ > > > > > > > > + > > > > > > > > +#ifndef IRDMA_ABI_H > > > > > > > > +#define IRDMA_ABI_H > > > > > > > > + > > > > > > > > +#include > > > > > > > > + > > > > > > > > +/* irdma must support legacy GEN_1 i40iw kernel > > > > > > > > + * and user-space whose last ABI ver is 5 */ #define > > > > > > > > +IRDMA_ABI_VER > > > > > > > > +6 > > > > > > > > > > > > > > Can you please elaborate about it more? > > > > > > > There is no irdma code in RDMA yet, so it makes me wonder why new > > > > > > > define shouldn't start from 1. > > > > > > > > > > > > It is because they are ABI compatible with the current user space, > > > > > > which raises the question why we even have this confusing header file.. > > > > > > > > > > It is because we need to support current providers/i40iw user-space. > > > > > Our user-space patch series will introduce a new provider (irdma) > > > > > whose ABI ver. is also 6 (capable of supporting X722 and which will > > > > > work with i40iw driver on older kernels) and removes providers/i40iw from rdma- > > > > core. > > > > > > > > Why on earth would we do that? > > > > > > > A unified library providers/irdma to go in hand with the driver irdma and uses the ABI header. > > > It can support the new network device e810 and existing x722 iWARP device. It obsoletes > > > providers/i40iw and extends its ABI. So why keep providers/i40iw around in rdma-core? > > > > Why rewrite a perfectly good userspace that is compatible with the > > future and past kernels? > > > > Is there something so wrong with the userspace provider to need this? > > > > Yes, the issue is that providers/i40iw was never designed to work with a unified driver > which supports multiple hardware generations. Do you plan to remove i40iw from kernel immediately after your irdma will be merged? Thanks > > Henry