From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D8E0C73C70 for ; Wed, 10 Jul 2019 05:27:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 069162083D for ; Wed, 10 Jul 2019 05:27:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562736473; bh=7L1PogGoEpn5Kd8aneV8mLaxZSNCTpPPc2eMzKiOKO8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=C81KbL1UeRXxTUKLnEMMC9QN1fqwaNMgnZga6yf2LR/l+zVqOvqdSwOqFUK+jBAf/ SUjRtfhJVk4FFuljch+jezh1X8hhMs97xzJplO/fw8foIyvjpvt7LEVS5xIM7XaNfs zx2J2F+S8L0KZqoFOCTCllPxbM4Er7uOSnshn/cM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727089AbfGJF1w (ORCPT ); Wed, 10 Jul 2019 01:27:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:49908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725932AbfGJF1v (ORCPT ); Wed, 10 Jul 2019 01:27:51 -0400 Received: from localhost (unknown [37.142.3.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3709A20665; Wed, 10 Jul 2019 05:27:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1562736470; bh=7L1PogGoEpn5Kd8aneV8mLaxZSNCTpPPc2eMzKiOKO8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Fao99MZDLEPFpKcxGrLYlGStt4Rk2hTF5HhRtch8AOxm+g9/mUQ/wO5/Z3zZmnlEr 2nNEaOsqg3pxr4Gn58O/0DyiAcnOnw6tThQ6oqSpJEmmdRH3R/v8zLiP0vXX9c+LKb bAriiEFNCFE2oNeIpB5PBb6sdD0EeZuV/ykrW8Xo= Date: Wed, 10 Jul 2019 08:27:46 +0300 From: Leon Romanovsky To: Saeed Mahameed Cc: "saeedm@dev.mellanox.co.il" , Eran Ben Elisha , "netdev@vger.kernel.org" , "linux-rdma@vger.kernel.org" , Tariq Toukan Subject: Re: [PATCH mlx5-next 4/5] net/mlx5: Introduce TLS TX offload hardware bits and structures Message-ID: <20190710052746.GE7034@mtr-leonro.mtl.com> References: <20190703073909.14965-1-saeedm@mellanox.com> <20190703073909.14965-5-saeedm@mellanox.com> <20190703092735.GZ4727@mtr-leonro.mtl.com> <20190704171519.GE7212@mtr-leonro.mtl.com> <20190704182113.GG7212@mtr-leonro.mtl.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jul 09, 2019 at 08:54:58PM +0000, Saeed Mahameed wrote: > On Thu, 2019-07-04 at 21:21 +0300, Leon Romanovsky wrote: > > On Thu, Jul 04, 2019 at 01:21:04PM -0400, Saeed Mahameed wrote: > > > On Thu, Jul 4, 2019 at 1:15 PM Leon Romanovsky > > > wrote: > > > > On Thu, Jul 04, 2019 at 01:06:58PM -0400, Saeed Mahameed wrote: > > > > > On Wed, Jul 3, 2019 at 5:27 AM wrote: > > > > > > On Wed, Jul 03, 2019 at 07:39:32AM +0000, Saeed Mahameed > > > > > > wrote: > > > > > > > From: Eran Ben Elisha > > > > > > > > > > > > > > Add TLS offload related IFC structs, layouts and > > > > > > > enumerations. > > > > > > > > > > > > > > Signed-off-by: Eran Ben Elisha > > > > > > > Signed-off-by: Tariq Toukan > > > > > > > Signed-off-by: Saeed Mahameed > > > > > > > --- > > > > > > > include/linux/mlx5/device.h | 14 +++++ > > > > > > > include/linux/mlx5/mlx5_ifc.h | 104 > > > > > > > ++++++++++++++++++++++++++++++++-- > > > > > > > 2 files changed, 114 insertions(+), 4 deletions(-) > > > > > > > > > > > > <...> > > > > > > > > > > > > > @@ -2725,7 +2739,8 @@ struct mlx5_ifc_traffic_counter_bits > > > > > > > { > > > > > > > > > > > > > > struct mlx5_ifc_tisc_bits { > > > > > > > u8 strict_lag_tx_port_affinity[0x1]; > > > > > > > - u8 reserved_at_1[0x3]; > > > > > > > + u8 tls_en[0x1]; > > > > > > > + u8 reserved_at_1[0x2]; > > > > > > > > > > > > It should be reserved_at_2. > > > > > > > > > > > > > > > > it should be at_1. > > > > > > > > Why? See mlx5_ifc_flow_table_prop_layout_bits, > > > > mlx5_ifc_roce_cap_bits, e.t.c. > > > > > > > > > > they are all at_1 .. so i don't really understand what you want > > > from me, > > > Leon the code is good, please double check you comments.. > > > > Saeed, > > > > reserved_at_1 should be renamed to be reserved_at_2. > > > > strict_lag_tx_port_affinity[0x1] + tls_en[0x1] = 0x2 > > > > Ok now it is clear, i trusted the developer on this one :) > anyway you have to admit that you mislead me with your examples: > mx5_ifc_flow_table_prop_layout_bits and mlx5_ifc_roce_cap_bits, they > both are fine so i though this was fine too. > > I will fix it up. Thanks > > Thanks, > Saeed. > > > > > Thanks > > > > > > > > > > Thanks