Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: chris.packham@alliedtelesis.co.nz
Cc: jon.maloy@ericsson.com, eric.dumazet@gmail.com,
	ying.xue@windriver.com, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH v2] tipc: ensure head->lock is initialised
Date: Fri, 12 Jul 2019 15:34:48 -0700 (PDT)	[thread overview]
Message-ID: <20190712.153448.2014775769142835466.davem@davemloft.net> (raw)
In-Reply-To: <20190711224115.21499-1-chris.packham@alliedtelesis.co.nz>

From: Chris Packham <chris.packham@alliedtelesis.co.nz>
Date: Fri, 12 Jul 2019 10:41:15 +1200

> tipc_named_node_up() creates a skb list. It passes the list to
> tipc_node_xmit() which has some code paths that can call
> skb_queue_purge() which relies on the list->lock being initialised.
> 
> The spin_lock is only needed if the messages end up on the receive path
> but when the list is created in tipc_named_node_up() we don't
> necessarily know if it is going to end up there.
> 
> Once all the skb list users are updated in tipc it will then be possible
> to update them to use the unlocked variants of the skb list functions
> and initialise the lock when we know the message will follow the receive
> path.
> 
> Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

Applied.

      parent reply	other threads:[~2019-07-12 22:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11 22:41 [PATCH v2] tipc: ensure head->lock is initialised Chris Packham
2019-07-12 13:35 ` Jon Maloy
2019-07-12 22:34 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190712.153448.2014775769142835466.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=chris.packham@alliedtelesis.co.nz \
    --cc=eric.dumazet@gmail.com \
    --cc=jon.maloy@ericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=ying.xue@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox